-
Notifications
You must be signed in to change notification settings - Fork 12
Week 3 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gagyeong17
wants to merge
4
commits into
CodeSoom:main
Choose a base branch
from
gagyeong17:week-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Week 3 #7
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,25 @@ | ||
| const bubbleSort = (array) => { | ||
| let swapped = false; | ||
|
|
||
| for (let i = 0; i < array.length; i++) { | ||
| for (let j = 0; j < array.length - 1 - i; j++) { | ||
| if (array[j] > array[j + 1]) { | ||
| swapped = true; | ||
| let temp = array[j]; | ||
| array[j] = array[j + 1]; | ||
| array[j + 1] = temp; | ||
| } | ||
| } | ||
| if (!swapped) return array; | ||
| } | ||
| return array; | ||
| }; | ||
|
|
||
| test.each([ | ||
| [[5, 4, 3, 2, 1]], | ||
| [[1, 2, 3, 4, 5]], | ||
| [[4, 2, 1, 5, 3]], | ||
| ])('주어진 배열을 오름차순으로 정렬한다', (array) => { | ||
| bubbleSort(array); | ||
| test.each([[[5, 4, 3, 2, 1]], [[1, 2, 3, 4, 5]], [[4, 2, 1, 5, 3]]])( | ||
| "주어진 배열을 오름차순으로 정렬한다", | ||
| (array) => { | ||
| bubbleSort(array); | ||
|
|
||
| expect(array).toEqual([1, 2, 3, 4, 5]); | ||
| }); | ||
| expect(array).toEqual([1, 2, 3, 4, 5]); | ||
| }, | ||
| ); | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,24 @@ | ||
| const selectionSort = (array) => { | ||
| for (let i = 0; i < array.length - 1; i++) { | ||
| let minIndex = i; | ||
| for (let j = i + 1; j < array.length; j++) { | ||
| if (array[j] < array[minIndex]) { | ||
| minIndex = j; | ||
| } | ||
| } | ||
| if (minIndex !== i) { | ||
| let temp = array[i]; | ||
| array[i] = array[minIndex]; | ||
| array[minIndex] = temp; | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| test.each([ | ||
| [[5, 4, 3, 2, 1]], | ||
| [[1, 2, 3, 4, 5]], | ||
| [[4, 2, 1, 5, 3]], | ||
| ])('주어진 배열을 오름차순으로 정렬한다', (array) => { | ||
| selectionSort(array); | ||
| test.each([[[5, 4, 3, 2, 1]], [[1, 2, 3, 4, 5]], [[4, 2, 1, 5, 3]]])( | ||
| "주어진 배열을 오름차순으로 정렬한다", | ||
| (array) => { | ||
| selectionSort(array); | ||
|
|
||
| expect(array).toEqual([1, 2, 3, 4, 5]); | ||
| }); | ||
| expect(array).toEqual([1, 2, 3, 4, 5]); | ||
| }, | ||
| ); |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,32 @@ | ||
| const exchange = (list, a, b) => { | ||
| [list[b], list[a]] = [list[a], list[b]]; | ||
| }; | ||
|
|
||
| const less = (a, b) => a < b; | ||
|
|
||
| const insertionSort = (array) => { | ||
| const { length } = array; | ||
|
|
||
| for (let i = 1; i < length; i++) { | ||
| for (let j = i; j > 0; j--) { | ||
| if (array[j] < array[j - 1]) { | ||
| [array[j - 1], array[j]] = [array[j], array[j - 1]]; | ||
| } else { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| test.each([ | ||
| [[5, 4, 3, 2, 1]], | ||
| [[1, 2, 3, 4, 5]], | ||
| [[4, 2, 1, 5, 3]], | ||
| ])('주어진 배열을 오름차순으로 정렬한다', (array) => { | ||
| insertionSort(array); | ||
| // 테스트 | ||
| let array = [5, 3, 8, 1, 2]; | ||
| console.log(insertionSort(array)); // [1, 2, 3, 5, 8] | ||
|
|
||
| test.each([[[5, 4, 3, 2, 1]], [[1, 2, 3, 4, 5]], [[4, 2, 1, 5, 3]]])( | ||
| "주어진 배열을 오름차순으로 정렬한다", | ||
| (array) => { | ||
| insertionSort(array); | ||
|
|
||
| expect(array).toEqual([1, 2, 3, 4, 5]); | ||
| }); | ||
| expect(array).toEqual([1, 2, 3, 4, 5]); | ||
| }, | ||
| ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미 정렬되어 있으면 더 이상 볼 필요없이 빠르게 종료하려고 하신 것 같습니다.
swapped가 최 상단에 있으면, 한 번 이라도 스왑이 일어나는 경우, 그 이후 단계에서 아무리 정렬되어 있어도 일찍 종료되지 않습니다.다음과 같이 초기화를 해줘야 �한 번의 패스스루에서 한 번도 스왑이 일어나지 않은 경우 빠르게 종료됩니다.