London_10-Saliha-Popal/HTML-CSS-Challenges #255
Conversation
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "liveServer.settings.port": 5503 | |||
| } No newline at end of file | |||
There was a problem hiding this comment.
In general, VS Code settings are not typically pushed to remote.
| margin-right: 1.5rem; | ||
|
|
||
| } | ||
| .btn1{ |
There was a problem hiding this comment.
Choose names that accurately describe the purpose or content of the element. This makes it easier for others (and your future self) to understand the code. I don't know which btn you mean by btn1 for example.
| } | ||
| .btn2{ | ||
| background-color: teal; | ||
| padding: 10px 32px; |
There was a problem hiding this comment.
You can use relative font sizes (such as em, rem, or percentages) instead of fixed pixel values to make your CSS code responsive.
migmow
left a comment
migmow
left a comment
There was a problem hiding this comment.
Hi Saliha, the CSS code you provided doesn't contain any specific rules for responsiveness, such as media queries or flexible layout properties. Not sure it is a requirement to make it responsive though! good job
|
Hi Shadi, thanks for your comments.
…On Fri, 9 Jun 2023 at 15:19, ShadiSafaee ***@***.***> wrote:
***@***.**** commented on this pull request.
Hi Saliha, the CSS code you provided doesn't contain any specific rules
for responsiveness, such as media queries or flexible layout properties.
Not sure it is a requirement to make it responsive though! good job
—
Reply to this email directly, view it on GitHub
<#255 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3CHYAZ4RNW7GBPDKBKM7JDXKMWG7ANCNFSM6AAAAAAXW2QPOQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
2 participants
I have done it before but did not PR.