This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London10_OLHA-DANYLEVSKA_JavaScript-Core-1-Coursework-week1 #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra/1-currency-conversion.js
Outdated
| function convertToUSD() {} | ||
| function convertToUSD(amount) { | ||
| return amount * 1.4; | ||
|
|
There was a problem hiding this comment.
This is a very small comment but it is customary to not add any extra lines if not needed, so you can erase these lines.
Author
There was a problem hiding this comment.
Hi @mcarballopacheco Thanks for your comment, could you please clarify which lines I can erase?
Thanks)
| "Very doubtful." | ||
| ]; | ||
|
|
||
| let answersArray = [ |
| //The concat() method is used to merge two or more arrays. This method does not change the existing arrays, but instead returns a new array. | ||
|
|
||
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| return firstWord + ' ' + secondWord + ' ' + thirdWord; |
There was a problem hiding this comment.
Good. You could have also used .concat.
added separate variables in "good" code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?