-
-
Notifications
You must be signed in to change notification settings - Fork 436
LND10 | Adrian Ilovan | JS1 Coursework Week2 #461
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,20 +10,16 @@ | |
| */ | ||
|
|
||
| function getMood() { | ||
| let isHappy = true; | ||
|
|
||
| if (isHappy) { | ||
| function getMood(isHappy) { | ||
| if (isHappy === true) { | ||
| return "I am happy"; | ||
| } else { | ||
| return "I am not happy"; | ||
| } | ||
| } | ||
|
|
||
| function greaterThan10(num) { | ||
| let isBigEnough; | ||
|
|
||
| if (isBigEnough) { | ||
| if (num > 10) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM |
||
| return "num is greater than 10"; | ||
| } else { | ||
| return "num is not big enough"; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,37 +4,73 @@ | |
| 1. the user should be 18 or older | ||
| 2. the user must be logged in | ||
| */ | ||
| function isAcceptableUser(userAge, isLoggedIn) {} | ||
|
|
||
| function isAcceptableUser(userAge, isLoggedIn) { | ||
| if (userAge >= 18 && isLoggedIn === true) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. perfect :) |
||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
|
|
||
| // if (isLoggedIn) { | ||
| // return true; | ||
| // } else { | ||
| // return false; | ||
| // } | ||
| } | ||
| /* | ||
| Complete the function to apply discount percent based on how much is totalPrice in user cart. | ||
| - When the total price is greater than 200, a 10% discount should be applied | ||
| - When the total price is less than 200, a 5% discount should be applied | ||
|
|
||
| The function should return the new price to be paid (e.g. if the totalPrice is 150, a 5% discount | ||
| is applieds and 142.5 should be returned) | ||
| is applied and 142.5 should be returned) | ||
| */ | ||
|
|
||
| function applyDiscount(totalPrice) {} | ||
|
|
||
| function applyDiscount(totalPrice) { | ||
| if (totalPrice > 200) { | ||
| return totalPrice - totalPrice * 0.1; // for 10% discount | ||
| } else { | ||
| return totalPrice - totalPrice * 0.05; // for 5% discount | ||
| } | ||
| } | ||
| /* | ||
| Complete the function to print to the console the odd numbers between 1 and limit (use a while loop): | ||
| */ | ||
| function printOddNumbers(limit) {} | ||
| function printOddNumbers(limit) { | ||
| let i = 1; | ||
| while (i <= limit) { | ||
| if (i % 2 !== 0) { | ||
| console.log(i); | ||
| } | ||
| i++; | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| Complete the buyTwoGetTheCheapestFree function: if user buys two items, the cheapest item will be free! | ||
| The function should return the price to be paid once the discount is applied. | ||
| */ | ||
| function buyTwoGetTheCheapestFree(price1, price2) {} | ||
| function buyTwoGetTheCheapestFree(price1, price2) { | ||
| let cheaperPrice = price1 < price2 ? price1 : price2; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good use of the ternary operator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have to be honest, ChatGPT helped. |
||
| let totalPrice = price1 + price2; | ||
| return totalPrice - cheaperPrice; | ||
| } | ||
|
|
||
| /* | ||
| Complete the function to determine if it is suitable for a person to register based on their age! | ||
| - if the person is 12 or younger it should return "You Are Too Young To Register" | ||
| - if the person is older than 12 and younger than 90 it should return "You Can Register" | ||
| - if the person is 90 or older it should return "You Don't Need To Register" | ||
| */ | ||
| function canRegister(age) {} | ||
| function canRegister(age) { | ||
| if (age <= 12) { | ||
| return "You Are Too Young To Register"; | ||
| } else if (age >= 12 && age < 90) { | ||
| return "You Can Register"; | ||
| } else { | ||
| return "You Don't Need To Register"; | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| Complete the function so that it prints out to the console numbers in reverse order starting at | ||
|
|
@@ -45,7 +81,11 @@ function canRegister(age) {} | |
| ) | ||
| */ | ||
|
|
||
| function countReverse(number) {} | ||
| function countReverse(number) { | ||
| for (let i = number; i >= 1; i--) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good for loop
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ta :) |
||
| console.log(i); | ||
| } | ||
| } | ||
|
|
||
| /* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
|
||
|
|
@@ -90,11 +130,11 @@ describe("printOddNumbers", () => { | |
| const consoleLogSpy = jest.spyOn(console, "log"); | ||
|
|
||
| printOddNumbers(10); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(1,1); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(2,3); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(3,5); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(4,7); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(5,9); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(1, 1); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(2, 3); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(3, 5); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(4, 7); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(5, 9); | ||
|
|
||
| consoleLogSpy.mockRestore(); | ||
| }); | ||
|
|
@@ -141,13 +181,13 @@ describe("countReverse", () => { | |
| const consoleLogSpy = jest.spyOn(console, "log"); | ||
|
|
||
| countReverse(7); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(1,7); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(2,6); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(3,5); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(4,4); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(5,3); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(6,2); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(7,1); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(1, 7); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(2, 6); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(3, 5); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(4, 4); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(5, 3); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(6, 2); | ||
| expect(consoleLogSpy).toHaveBeenNthCalledWith(7, 1); | ||
|
|
||
| consoleLogSpy.mockRestore(); | ||
| }); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice using strict equality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)