style(GlobalHeader): Use theme variable for header height #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecaaron
requested review from
christian-dinh,
dreamwasp,
jakemhiller,
katiezutter and
saghdaey
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #1469 +/- ##
=======================================
Coverage 83.27% 83.27%
=======================================
Files 336 336
Lines 2774 2775 +1
Branches 712 712
=======================================
+ Hits 2310 2311 +1
Misses 412 412
Partials 52 52
|
saghdaey
reviewed
Mar 5, 2021
| <> | ||
| <Box | ||
| display={{ base: 'none', md: 'block' }} | ||
| height={theme.elements.headerHeight} |
Contributor
There was a problem hiding this comment.
wowowow!! wait did @katiezutter know you were working on this
katiezutter
approved these changes
Mar 5, 2021
Contributor
katiezutter
left a comment
katiezutter
left a comment
There was a problem hiding this comment.
This seriously made my day 🙌
christian-dinh
approved these changes
Mar 5, 2021
Contributor
christian-dinh
left a comment
christian-dinh
left a comment
There was a problem hiding this comment.
hell yea 🔥
I guess I can just close https://github.com/Codecademy/client-modules/pull/1417 then?
Contributor
Author
If you still are gonna use the utility you can just pull this one into that and we can get these headers ANIMATED :) |
Collaborator
📬Published Alpha Packages:@codecademy/gamut-kit@0.2.2-alpha.bf1678.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Time for some magic.
PR Checklist