Skip to content

Improve convoluted code and fix building outside of Windows platforms #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve convoluted code and fix building outside of Windows platforms #1

wants to merge 4 commits into from

Conversation

Vortex2Oblivion
Copy link

@Vortex2Oblivion Vortex2Oblivion commented Jun 17, 2025 •
edited
Loading

basically just fix that duplicated code into one function
also linux actually builds now lol

@Vortex2Oblivion Vortex2Oblivion changed the title fix some questionable coding choices fix some code Jun 17, 2025
@crowplexus
Copy link
Member

I'm gonna test this shortly since I'm on Linux, I'll be the judge of that

@Vortex2Oblivion
Copy link
Author

I'm gonna test this shortly since I'm on Linux, I'll be the judge of that

i mean
it didnt work
i added the define
it worked
so..

@crowplexus crowplexus self-assigned this Jun 17, 2025
@crowplexus crowplexus added type:enhancement New feature or request state:good first issue Good for newcomers labels Jun 17, 2025
@crowplexus crowplexus changed the title fix some code Improve convoluted code and fix building outside of Windows platforms Jun 17, 2025
@crowplexus crowplexus added the severity:tame This issue/pull request could be looked into later, post-release or later. label Jun 17, 2025
@Vortex2Oblivion
Copy link
Author

probably gonna edit this to just use a ::Array instead of an std::vector to avoid the conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crowplexus crowplexus

Labels
severity:tame This issue/pull request could be looked into later, post-release or later. state:good first issue Good for newcomers type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vortex2Oblivion @crowplexus