Skip to content

Deleting unresolved memory bug #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitjanZ merged 1 commit into from
Mar 17, 2026
Merged

Deleting unresolved memory bug #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions memory_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def create_conformance_tests_memory(
existing_files, existing_files_content = ImplementationCodeHelpers.fetch_existing_files(
render_context.build_folder
)
_, memory_files_content = MemoryManager.fetch_memory_files(self.memory_folder)
memory_files, memory_files_content = MemoryManager.fetch_memory_files(self.memory_folder)

conformance_tests_folder_name = (
render_context.conformance_tests_running_context.get_current_conformance_test_folder_name()
Expand Down Expand Up @@ -96,7 +96,7 @@ def create_conformance_tests_memory(
)
if len(response_files) > 0:
memory_folder_path = os.path.join(self.memory_folder, CONFORMANCE_TEST_MEMORY_SUBFOLDER)
file_utils.store_response_files(memory_folder_path, response_files, existing_files)
file_utils.store_response_files(memory_folder_path, response_files, memory_files)

def delete_unresolved_memory_files(self):
"""Delete memory files whose resolution_status is not 'RESOLVED'."""
Expand Down
8 changes: 7 additions & 1 deletion render_machine/actions/run_conformance_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,13 @@ def execute(self, render_context: RenderContext, _previous_action_payload: Any |
)

if exit_code == 0:
render_context.memory_manager.delete_unresolved_memory_files()
if (
render_context.conformance_tests_running_context.current_testing_module_name
== render_context.module_name
and render_context.conformance_tests_running_context.current_testing_frid
== render_context.frid_context.frid
):
render_context.memory_manager.delete_unresolved_memory_files()
return self.SUCCESSFUL_OUTCOME, None

if exit_code in UNRECOVERABLE_ERROR_EXIT_CODES:
Expand Down
Loading