Open
Conversation
NejcS
force-pushed
the
feat/improve_render_error_console_output
branch
from
b076c99 to
293c923
Compare
Contributor
pedjaradenkovic
left a comment
pedjaradenkovic
left a comment
There was a problem hiding this comment.
The rest of the changes looks good.
I just think that we should move the error message creation to the place where the error is happening. What do you think?
| exc_info = sys.exc_info() | ||
| console.error(f"Credit balance too low: {str(e)}\n") | ||
| console.debug(f"Render ID: {run_state.render_id}") | ||
| error_message = f"Credit balance too low: {str(e)}\n" |
Contributor
There was a problem hiding this comment.
I would refactor all of those exceptions to be initialised with a proper error message that can be displayed so that each exception can be changed to one line that catches them all and just prints what was written. Does that make sense?
Contributor
Author
There was a problem hiding this comment.
Makes sense. I did that in the latest commits.
Contributor
Author
There was a problem hiding this comment.
Tried raising a couple of types of exceptions and it works fine.
NejcS
force-pushed
the
feat/improve_render_error_console_output
branch
from
9d6f8d4 to
5d318d9
Compare
NejcS
force-pushed
the
feat/improve_render_error_console_output
branch
from
3e223c0 to
72aff66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Reopend this PR and closed other one because of rebasing mess.
Changes:
with console.status('...'):because those polluted the post rendering console outputExample outputs of failed renders:
