Merged
Conversation
pedjaradenkovic
requested review from
pedjaradenkovic
and removed request for
zanjonke
NejcS
force-pushed
the
fix/log_entry_timestamps_subtract_pause_time
branch
from
ca50f78 to
6c4dac4
Compare
NejcS
changed the title
Contributor
Author
|
@pedjaradenkovic this is ready for review. Essentially, the change from your previous review is that where is called but that's suboptimal as well. |
NejcS
force-pushed
the
fix/log_entry_timestamps_subtract_pause_time
branch
from
850813b to
91657bd
Compare
Contributor
Author
|
@pedjaradenkovic I updated with the naming change we talked about. |
NejcS
force-pushed
the
fix/log_entry_timestamps_subtract_pause_time
branch
from
8b67be4 to
6f2d47a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the log entries in the log view that had wrong timestamps in case the user paused rendering. This PR changes so that the pause time is not included in the timestamps.