Skip to content

Fix memory creation triggering across different modules with same frid #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedjaradenkovic merged 1 commit into from
Apr 24, 2026
Merged

Fix memory creation triggering across different modules with same frid #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions memory_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,29 @@ def create_conformance_tests_memory(
):

current_conformance_tests_issue_frid = render_context.conformance_tests_running_context.current_testing_frid
current_conformance_tests_issue_module = (
render_context.conformance_tests_running_context.current_testing_module_name
)
old_conformance_tests_issue_frid = (
render_context.conformance_tests_running_context.previous_conformance_tests_issue_frid
)
old_conformance_tests_issue_module = (
render_context.conformance_tests_running_context.previous_conformance_tests_issue_module
)

old_conformance_tests_issue = (
render_context.conformance_tests_running_context.previous_conformance_tests_issue_old
)

is_first_time_running_conformance_tests = (
old_conformance_tests_issue_frid is None or old_conformance_tests_issue_frid == ""
old_conformance_tests_issue_frid is None
or old_conformance_tests_issue_frid == ""
or old_conformance_tests_issue_module != current_conformance_tests_issue_module
)
is_same_frid_as_previous_failing_test = (
current_conformance_tests_issue_frid == old_conformance_tests_issue_frid
and current_conformance_tests_issue_module == old_conformance_tests_issue_module
)
is_same_frid_as_previous_failing_test = current_conformance_tests_issue_frid == old_conformance_tests_issue_frid
is_conformance_test_failed = exit_code != CONFORMANCE_TESTS_SUCCESS_EXIT_CODE

should_create_memory = not is_first_time_running_conformance_tests and (
Expand Down
3 changes: 3 additions & 0 deletions render_machine/actions/fix_conformance_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ def execute(self, render_context: RenderContext, previous_action_payload: Any |
render_context.conformance_tests_running_context.previous_conformance_tests_issue_frid = (
render_context.conformance_tests_running_context.current_testing_frid
)
render_context.conformance_tests_running_context.previous_conformance_tests_issue_module = (
render_context.conformance_tests_running_context.current_testing_module_name
)

if render_context.conformance_tests_running_context.current_testing_frid == render_context.frid_context.frid:
console_message = f"Fixing conformance test for functionality {render_context.conformance_tests_running_context.current_testing_frid} in module {render_context.conformance_tests_running_context.current_testing_module_name}."
Expand Down
1 change: 1 addition & 0 deletions render_machine/render_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def __init__(
self.current_testing_frid_high_level_implementation_plan: Optional[str] = None
self.previous_conformance_tests_issue_old: Optional[str] = None
self.previous_conformance_tests_issue_frid: Optional[str] = None
self.previous_conformance_tests_issue_module: Optional[str] = None
self.code_diff_files: Optional[dict[str, str]] = None

def get_conformance_tests_json(self, module_name: str) -> dict:
Expand Down
Loading