Fix keyboard navigation crash when context menu has no filtered results#62
Merged
Coder-Harshit merged 2 commits intouxfrom Dec 19, 2025
Merged
Fix keyboard navigation crash when context menu has no filtered results#62Coder-Harshit merged 2 commits intouxfrom
Coder-Harshit merged 2 commits intouxfrom
Conversation
Co-authored-by: Coder-Harshit <93333205+Coder-Harshit@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on limiting target node handles to one input
Fix keyboard navigation crash when context menu has no filtered results
Dec 19, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in keyboard navigation when the context menu has no filtered results. The issue occurred when users pressed arrow keys with an empty search result, causing NaN from modulo-by-zero operations and negative indices.
- Added guard conditions to prevent keyboard navigation when
filteredActionsis empty - Guards prevent
(prev + 1) % 0→NaNand0 - 1→-1edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyboard navigation in
ContextMenu.tsxcrashes whenfilteredActionsis empty due to modulo-by-zero and negative index operations.Changes
handleKeyDownfor ArrowDown/ArrowUp navigation(prev + 1) % 0→NaNand0 - 1→-1when no results existThe existing
useEffectalready resetsselectedIndexto 0 whenfilteredActionschanges, so state remains consistent.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.