Open
Conversation
…uage selector Add toggle functionality for language selector
Member
Author
|
@majdkt I finally invested some time in fixing the merge conflicts 🎉 Could you please give this a quick look to see if there are any concerns from your side? |
Kaes3kuch3n
force-pushed
the
header-footer
branch
from
bca9145 to
741128a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adjusts the styling of the header and footer components to match our Figma design. Additionally it adds internationalisation via a JSON file for individual strings and via localized subdirectories for whole pages or markdown content.
It also removes the dark mode toggle button from the header for now, since the new color scheme isn't finalized yet and we don't want to add the additional overhead of supporting a secondary color scheme which also has to match our standards for accessibility until this has been finalized.