Skip to content

feat: add 1 Tier 1a/1b corrected reduction rules (#770)#915

Closed
zazabap wants to merge 1 commit intomainfrom
feat/770-warn-batch
Closed

feat: add 1 Tier 1a/1b corrected reduction rules (#770)#915
zazabap wants to merge 1 commit intomainfrom
feat/770-warn-batch

Conversation

@zazabap
Copy link
Copy Markdown
Collaborator

@zazabap zazabap commented Mar 29, 2026

Summary

Add 1 corrected Tier 1a/1b reduction rules from #770.

Implemented

Fixes #166

Implement the classic NAE-3-SAT → MaxCut reduction via variable gadgets
(complementary vertex pairs with weight M = 2m+1) and clause triangles.
Each NAE-satisfied clause contributes exactly 2 cut edges, giving a tight
threshold of nM + 2m.

Includes reduction rule, unit tests (7 tests), canonical example_db entry,
paper entry, and updated dominated-rules allow-list.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

❌ Patch coverage is 99.28058% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.87%. Comparing base (006d468) to head (c643512).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/naesatisfiability_maxcut.rs 98.21% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #915    +/-   ##
========================================
  Coverage   97.87%   97.87%            
========================================
  Files         631      633     +2     
  Lines       69046    69184   +138     
========================================
+ Hits        67577    67714   +137     
- Misses       1469     1470     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zazabap zazabap closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Rule] KSatisfiability to MaxCut

1 participant