a beautiful print method + real error throwing/checking#123
Open
arjunpat wants to merge 2 commits intoCodingTrain:masterfrom
arjunpat:patch-1
Open
a beautiful print method + real error throwing/checking#123arjunpat wants to merge 2 commits intoCodingTrain:masterfrom arjunpat:patch-1
arjunpat wants to merge 2 commits intoCodingTrain:masterfrom
arjunpat:patch-1
Conversation
-refactored errors to JavaScript convention -created a beautiful print method (try it in Google Chrome) -cut down if statements and for statements where brackets weren't needed
Author
|
Just wanted to let you know that the error checking breaks the circleci test (but it will not people's code — it makes it MORE failsafe against bad inputs. It also removes the need for an empty return statement as throwing errors automatically breaks the program). I am submitting code that breaks the test because it is usually more conventional to throw errors in javascript (especially errors that could cause the program to go haywire). Also, it will break the print test because the new print method does not use console.table(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-refactored errors to JavaScript convention
-created a beautiful print method (try it in Google Chrome)
-cut down if statements and for statements where brackets weren't needed