Skip to content

Fix redis lua library vulnerabilities (CVE-2024-31449, CVE-2025-49844) #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix redis lua library vulnerabilities (CVE-2024-31449, CVE-2025-49844) #1763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59079b9
Fix lua UAF (CVE-2025-49844) - Redishell
KIMDONGYEON00 Oct 20, 2025
0152037
Fix lua bit.tohex (CVE-2024-31449)
KIMDONGYEON00 Oct 20, 2025
9f829b1
Added lua bit.tohex bug test (CVE-2024-31449)
KIMDONGYEON00 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion extern/redis-3.2.11/deps/lua/src/lparser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,13 +384,17 @@ Proto *luaY_parser (lua_State *L, ZIO *z, Mbuffer *buff, const char *name) {
struct LexState lexstate;
struct FuncState funcstate;
lexstate.buff = buff;
luaX_setinput(L, &lexstate, z, luaS_new(L, name));
TString *tname = luaS_new(L, name);
setsvalue2s(L, L->top, tname);
incr_top(L);
luaX_setinput(L, &lexstate, z, tname);
open_func(&lexstate, &funcstate);
funcstate.f->is_vararg = VARARG_ISVARARG; /* main func. is always vararg */
luaX_next(&lexstate); /* read first token */
chunk(&lexstate);
check(&lexstate, TK_EOS);
close_func(&lexstate);
--L->top;
lua_assert(funcstate.prev == NULL);
lua_assert(funcstate.f->nups == 0);
lua_assert(lexstate.fs == NULL);
Expand Down
1 change: 1 addition & 0 deletions extern/redis-3.2.11/deps/lua/src/lua_bit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ static int bit_tohex(lua_State *L)
const char *hexdigits = "0123456789abcdef";
char buf[8];
int i;
if (n == INT32_MIN) n = INT32_MIN+1;
if (n < 0) { n = -n; hexdigits = "0123456789ABCDEF"; }
if (n > 8) n = 8;
for (i = (int)n; --i >= 0; ) { buf[i] = hexdigits[b & 15]; b >>= 4; }
Expand Down
6 changes: 6 additions & 0 deletions extern/redis-3.2.11/tests/unit/scripting.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,12 @@ start_server {tags {"scripting"}} {
set e
} {*ERR*attempted to create global*}

test {lua bit.tohex bug} {
set res [run_script {return bit.tohex(65535, -2147483648)} 0]
r ping
set res
} {0000FFFF}

test {Test an example script DECR_IF_GT} {
set decr_if_gt {
local current
Expand Down