Skip to content

feat(ci): add github workflow for container build#765

Open
AleeRezaa wants to merge 12 commits intoCodyTseng:masterfrom
AleeRezaa:master
Open

feat(ci): add github workflow for container build#765
AleeRezaa wants to merge 12 commits intoCodyTseng:masterfrom
AleeRezaa:master

Conversation

@AleeRezaa
Copy link
Copy Markdown

(for testing purpose i had directly commit these in my fork's master branch, squash merge is recommended)

@CodyTseng
Copy link
Copy Markdown
Owner

Do you actually need Docker-based deployment for this 🤔? This project doesn’t really have proper versioning, I basically push everything straight to the master branch. Publishing a Docker image on every commit doesn’t seem like a great idea haha.

@AleeRezaa
Copy link
Copy Markdown
Author

I just had converted my whole webserver configuration and services i run on my server to a single docker-compose and i thought as docker compose does not have a way to even check for container updates without recompiling(i am not compose expert maybe it has but i don't know) it would be nice to create a prebuilt jumble image for easier deployment. about publishing docker image on every commit you are right and it don't seems a good idea.

how about publishing a docker image per day if new commit has been pushed? (maybe with no version or git commit hash tagging so new version will override previous image and avoids unnecessary docker store storage occupying)

@CodyTseng
Copy link
Copy Markdown
Owner

Maybe I should get versioning sorted out, for example using a monthly release tag like vYY.MM.

Alternatively, you could write a simple script that periodically pulls the latest code and triggers a build whenever there are updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants