Fix notification email showing wrong order total ($149.99 displayed as $1.50)#10
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Conversation
Root cause: NotificationRenderer.FormatCurrency() incorrectly divided the
amount by 100, assuming TotalAmount was transmitted in cents. However, the
OrderPlacedEvent.TotalAmount is already in dollars (decimal), so the division
produced wrong values (e.g. $149.99 / 100 = $1.4999, displayed as $1.50).
Fix: Remove the erroneous division by 100. The amount is formatted directly
using ToString("C2") since it is already in the correct dollar unit.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Order confirmation notification emails were displaying incorrect totals — a $149.99 order appeared as $1.50 in the email preview.
Root cause:
NotificationRenderer.FormatCurrency()divided the amount by 100, assumingTotalAmountwas transmitted in cents. However,OrderPlacedEvent.TotalAmount(defined inShared.Contracts) is adecimalalready representing dollars. The division produced149.99 / 100 = 1.4999, which formatted as$1.50.Fix: Remove the erroneous
/100mdivision and the misleading comment. The amount is now formatted directly viaToString("C2").Before / After
Review & Testing Checklist for Human
TotalAmountin cents. The removed comment claimed cents were intentional. Confirm that all producers ofOrderPlacedEvent(including any RabbitMQ publishers not in this repo) send dollar amounts, not cent amounts. If any producer does send cents, this fix is incorrect and the producer needs to change instead./api/notification/events/order-placedwith{"orderId":"11111111-1111-1111-1111-111111111111","customerId":"22222222-2222-2222-2222-222222222222","totalAmount":149.99,"placedAt":"2026-03-17T12:00:00Z"}and verify the preview shows $149.99.0.01,0.99,1000.00, and0to ensure formatting is correct across the board.Notes
FormatCurrency; consider adding tests to prevent regressions.ToString("C2")is locale-dependent — it uses the server's current culture for the currency symbol. This is pre-existing behavior, not introduced by this change.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/ed836c8f8ffb4732b029cbd48d7cad1e