fix: remove strikethrough on Client dropdown label in Work Entries page#461
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: remove strikethrough on Client dropdown label in Work Entries page#461devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
…own label The MUI outlined Select component requires a 'label' prop to create a proper notch in the border for the InputLabel text. Without it, the border line renders through the label, creating a strikethrough appearance.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a UI bug on the
/work-entriespage where the Client dropdown label appeared with a strikethrough. The outlined border was rendering through the label text because the MUI<Select>component was missing thelabelprop.In MUI's outlined variant,
<Select>needs alabelprop matching the<InputLabel>text so it can calculate the proper notch/gap in the fieldset border. Without it, the border renders straight through the label.Before — border cuts through "Client" label:
After — border properly notches around the label:
Review & Testing Checklist for Human
/work-entries, click "Add Work Entry", and confirm the "Client" label displays cleanly without a strikethroughNotes
label="Client"to the<Select>component to match the existing<InputLabel>Client</InputLabel>TextField,DatePicker) already handle this correctly via their ownlabelpropsLink to Devin session: https://partner-workshops.devinenterprise.com/sessions/21a7ea2e9e9f47f0ac809d285964aadf