fix: resolve strikethrough on Client dropdown label in Work Entries page#464
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: resolve strikethrough on Client dropdown label in Work Entries page#464devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
…dropdown label The MUI Select component in the WorkEntriesPage was missing the 'label' prop, which prevented the outlined fieldset from creating a proper notch for the label text. This caused the border to render through the label, creating a strikethrough appearance.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Client dropdown on the
/work-entriespage displayed a strikethrough on its label. The MUI outlinedSelectcomponent was missing thelabelprop, which prevents MUI from creating a proper notch in the fieldset border for the label text. Without it, the border line renders straight through the label.Added
label="Client"to theSelectcomponent to match the existingInputLabel, consistent with how the Reports page already handles its Select component.Before:
After:
Review & Testing Checklist for Human
/work-entriespage, click "Add Work Entry", and verify the Client dropdown label no longer has a strikethroughNotes
labelprop onSelect) was already used correctly inReportsPage.tsx— this fix bringsWorkEntriesPage.tsxin line with that.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/fed3787d437b460680227291e4790f38