fix: add label prop to Client Select to fix strikethrough on dropdown label#469
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Conversation
… label The MUI Select component was missing the label='Client' prop, which caused the outlined fieldset notch to not cut through the border for the label text. This made the border line pass through the label, creating a strikethrough effect.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a UI bug on the
/work-entriespage where the "Client" dropdown label appeared with a strikethrough. The MUI<Select>component was missing thelabel="Client"prop, which is required for the outlined variant to properly cut a notch in the fieldset border for the label. Without it, the border line renders through the label text, creating a visual strikethrough.Before: The border passes through the "Client" label text
After: The notch correctly accommodates the label
Review & Testing Checklist for Human
/work-entriespage, click "Add Work Entry", and verify the "Client" dropdown label no longer has a strikethrough<Select>components in the codebase that may have the same missinglabelprop issue (e.g., inClientsPage.tsx,ReportsPage.tsx)Notes
Selectneeds alabelprop matching itsInputLabelwhen using the outlined variant.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/d3d2ddc6880441bfb7b3724a65d9794f