Fix: Remove strikethrough on Client dropdown label in Work Entries page#484
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Fix: Remove strikethrough on Client dropdown label in Work Entries page#484devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
…own label The MUI Select component in the Add Work Entry dialog was missing the label prop. Without it, the outlined variant's fieldset border doesn't create a notch around the InputLabel text, causing the border to render through the label — appearing as a strikethrough.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
label="Client"prop to the MUI<Select>component in the "Add/Edit Work Entry" dialog on the/work-entriespage.Without this prop, MUI's outlined variant doesn't create a notch in the fieldset border around the
<InputLabel>text, causing the border to render through the label — appearing as a strikethrough.Before:
After:
Review & Testing Checklist for Human
/work-entries, click "Add Work Entry", and verify the "Client" dropdown label no longer has a strikethroughNotes
label="Client"to the<Select>component to match the existing<InputLabel>Client</InputLabel>Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/05dc8262e8284300940a4c12df5f0161