Skip to content

Conversation

@CaglarKullu
Copy link

I have created a commitment template section UI according to the Figma best of my abilities. Please review the code so I can make improvements/refactoring if necessary.

Copy link

@andre-tm-hui andre-tm-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty solid - looks easy to develop further when templates are supported. Just small aesthetic changes that I think would neaten up the widget. Thoughts @dromerolovo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the CommitmentItem widget, which supports customization. It offers three different item types: simple, addButton, and statusChecker, as defined by the CommitmentItemType enumeration. Currently, the child widget is hard-coded, but maybe we can pass it as a parameter, so that it supports the CommitmentItemForm and the data(Tags, Description, Points,). The effect that you implemented is nice, so perhaps we can incorporate it into the CommitmentItem widget. This way, we can avoid having two similar widgets and use just one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dromerolovo I need to ask to get it better, should I implement an expandable card widget as a third item type in the enum and add it under or a generic child type in the enum and then pass expandable card as a type of CommitmentItem where I use? Thank you so much for your attention and time.

@CollActionteam CollActionteam deleted a comment from andre-tm-hui Jun 23, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Visit the preview URL for this PR (updated for commit fe5f757):

https://collaction-development--pr73-enhancement-gh-61-ch-ieu4tmaf.web.app

(expires Wed, 12 Jul 2023 12:52:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2cf09e8dbf51d2eab3fc6679b673d248bc8047bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants