N°8402 - fix(ActionSlackNotification): Improve TransformHTMLToSlackMarkup with… #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Symptom
The CKEditor in iTop 3.2 doesn't add newlines anymore after headers and paragraphs in the underlaying HTML code.
Reproduction procedure
Cause
The updated CKE does not include newlines between html tags anymore.
This results in the following message markdown on Slack:
Proposed solution
Add newline (
\n) after paragraphs (p), headers (h1,h2,h3), list items (li) and code blocks.Similar to what has been done in 7150630 for MS Teams.
Checklist before requesting a review