Skip to content

Conversation

@peckpeck
Copy link
Contributor

@peckpeck peckpeck commented Sep 10, 2025

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket? -
Type of change? Bug fix

Symptom (bug)

Since we upgraded to itop 3.2.2 our webhooks failed to run.
Our webhook use a payload call back we wrote and our webhook service told told us that there was no payload.

Reproduction procedure (bug)

On iTop 3.2.2
Create a webhook and use a callback to create the payload instead of a JSON.
The payload is empty on calls.

Cause (bug)

See 1 line fix

Proposed solution (bug and enhancement)

See 1 line fix

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • Would a unit test be relevant and have I added it?
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

@github-project-automation github-project-automation bot moved this to First review needed in Combodo PRs dashboard Sep 10, 2025
@jf-cbd jf-cbd merged commit 763841d into Combodo:master Sep 11, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from First review needed to Finished in Combodo PRs dashboard Sep 11, 2025
@jf-cbd jf-cbd changed the title Fix webhook with prepare_payload_callback N°8698 - Fix webhook with prepare_payload_callback Sep 11, 2025
@jf-cbd
Copy link
Member

jf-cbd commented Sep 11, 2025

Hello @peckpeck, thanks for the fix !

@jf-cbd
Copy link
Member

jf-cbd commented Sep 11, 2025

We send stickers to people from the community that helped us to improve iTop (or its extensions), would you like to get some ? If yes, please text me at community[at]combodo.com and telling me the address you'd like to receive them.
Have a nice day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants