Skip to content

Conversation

@ekotriono
Copy link

File translations Bahasa Indonesia

@jf-cbd
Copy link
Member

jf-cbd commented Oct 6, 2025

Hey @ekotriono, thank you for your contribution !
It's really nice to add a new language to iTop's ecosystem, but only users having customer survey extension will be able to select it, while most of iTop user won't benefit from it 😔
Do you think it would be possible for you to add translations to iTop so that all iTop users will be able to choose Bahasa Indonesia language ?
Thanks in advance 😊

/**
* Localized data
*
* @copyright Copyright (C) 2010-2018 Combodo SARL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @copyright Copyright (C) 2010-2018 Combodo SARL
* @copyright Copyright (C) 2025 Combodo SARL


'Class:QuizzValueQuestion' => 'Pertanyaan pilihan khusus',
'Class:QuizzValueQuestion+' => 'Pilih satu pilihan dari daftar nilai (khusus untuk pertanyaan ini)',
'Class:QuizzValueQuestion/Name' => '%1$s) %2$s',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Suggested change
'Class:QuizzValueQuestion/Name' => '%1$s) %2$s',
'Class:QuizzValueQuestion/Name' => '(%1$s) %2$s',

(I see it is like this as well in original EN dictionary..)

Comment on lines +281 to +282
'Class:Quizz/Attribute:language/Value:Indonesian (Bahasa Indonesia)' => 'Indonesia (Bahasa Indonesia)',
'Class:Quizz/Attribute:language/Value:Indonesian (Bahasa Indonesia)+' => '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indonesian does not seem to be one of the values from the list:

<field id="language" xsi:type="AttributeApplicationLanguage">
<values>
<value>Brazilian (Brazilian)</value>
<value>Hungarian (Magyar)</value>
<value>Chinese (简体中文)</value>
<value>Dutch (Nederlands)</value>
<value>English (English)</value>
<value>German (Deutsch)</value>
<value>Russian (Русский)</value>
<value>Spanish (Español, Castellaño)</value>
<value>French (Français)</value>
<value>Japanese (日本語)</value>
<value>Turkish (Türkçe)</value>
<value>Danish (Dansk)</value>
<value>Czech (Čeština)</value>
<value>Italian (Italiano)</value>
</values>

You might need to add that in this PR.

'Class:SurveyTargetAnswer/Attribute:org_id_obsolescence_flag+' => '',
'Class:SurveyTargetAnswer/Attribute:last_question_id_finalclass_recall' => 'Pemanggilan kembali kelas akhir id pertanyaan terakhir',
'Class:SurveyTargetAnswer/Attribute:last_question_id_finalclass_recall+' => '',
)); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a final newline.

@jf-cbd jf-cbd moved this from First review needed to Hacktoberfest in Combodo PRs dashboard Oct 7, 2025
@jf-cbd
Copy link
Member

jf-cbd commented Oct 31, 2025

@ekotriono Hello, could you please take a look at the previous comments ? Thank you in advance

@jf-cbd jf-cbd moved this from Hacktoberfest to Pending contributor update in Combodo PRs dashboard Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Pending contributor update

Development

Successfully merging this pull request may close these issues.

3 participants