Skip to content

N°8768 - Fix deletion of Person notified #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-dumas merged 2 commits into from
Nov 13, 2025
Merged

N°8768 - Fix deletion of Person notified #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
951ba33
N°8768 - Fix deletion of Person notified
v-dumas Nov 13, 2025
7a12fef
N°8768 - Keep standard ExternalKey on lnkActionNotificationToContact
v-dumas Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 37 additions & 15 deletions core/datamodel.core.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
<itop_design xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="3.2">
<classes>
<class id="lnkActionNotificationToContact" _delta="define">
<parent>cmdbAbstractObject</parent>
<parent>DBObject</parent>
<properties>
<category>core/cmdb,application</category>
<is_link>1</is_link>
<category>core/cmdb,view_in_gui</category>
<abstract>false</abstract>
<key_type>autoincrement</key_type>
<db_table>priv_lnk_action_notif_to_contact</db_table>
Expand Down Expand Up @@ -42,18 +43,21 @@
<target_class>ActionNotification</target_class>
<default_value/>
<is_null_allowed>false</is_null_allowed>
<on_target_delete>DEL_AUTO</on_target_delete>
</field>
<field id="contact_id" xsi:type="AttributeExternalKey">
<sql>contact_id</sql>
<target_class>Contact</target_class>
<default_value/>
<is_null_allowed>false</is_null_allowed>
<on_target_delete>DEL_AUTO</on_target_delete>
</field>
<field id="trigger_id" xsi:type="AttributeExternalKey">
<sql>trigger_id</sql>
<target_class>Trigger</target_class>
<default_value/>
<is_null_allowed>false</is_null_allowed>
<on_target_delete>DEL_AUTO</on_target_delete>
</field>
<field id="subscribed" xsi:type="AttributeBoolean">
<sql>subscribed</sql>
Expand All @@ -66,18 +70,17 @@
<items>
<item id="col:col1">
<items>
<item id="fieldset:lnkActionNotificationToContact:content">
<items>
<item id="action_id">
<rank>10</rank>
</item>
<item id="contact_id">
<rank>20</rank>
</item>
<item id="title">
<rank>30</rank>
</item>
</items>
<item id="action_id">
<rank>10</rank>
</item>
<item id="contact_id">
<rank>20</rank>
</item>
<item id="trigger_id">
<rank>30</rank>
</item>
<item id="subscribed">
<rank>40</rank>
</item>
</items>
</item>
Expand All @@ -91,11 +94,30 @@
<item id="contact_id">
<rank>20</rank>
</item>
<item id="title">
<item id="trigger_id">
<rank>30</rank>
</item>
<item id="subscribed">
<rank>40</rank>
</item>
</items>
</list>
<default_search>
<items>
<item id="contact_id">
<rank>10</rank>
</item>
<item id="action_id">
<rank>20</rank>
</item>
<item id="trigger_id">
<rank>30</rank>
</item>
<item id="subscribed">
<rank>40</rank>
</item>
</items>
</default_search>
</presentation>
<methods/>
</class>
Expand Down
25 changes: 23 additions & 2 deletions dictionaries/cs.dictionary.itop.core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,25 @@
Dict::Add('CS CZ', 'Czech', 'Čeština', [
'Class:ActionNotification' => 'Upozornění',
'Class:ActionNotification+' => 'Upozornění (abstraktní)',
'Class:ActionNotification/Attribute:language' => 'Language~~',
'Class:ActionNotification/Attribute:language+' => '~~',
'Class:ActionNotification/Attribute:language' => 'Jazyk',
'Class:ActionNotification/Attribute:language+' => 'Jazyk použitý pro zástupné znaky ($xxx$) uvnitř zprávy (stav, důležitost, priorita atd.)',
]);

//
// Class: lnkActionNotificationToContact
//

Dict::Add('CS CZ', 'Czech', 'Čeština', [
'Class:lnkActionNotificationToContact' => 'Link ActionNotification / Contact~~',
'Class:lnkActionNotificationToContact+' => 'Contact subscription to Notification Action~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id' => 'Contact~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id+' => 'Contact who subscribed (or not) to the notification~~',
'Class:lnkActionNotificationToContact/Attribute:action_id' => 'Action~~',
'Class:lnkActionNotificationToContact/Attribute:action_id+' => 'The notification that the contact received at least once, and to which he can subscribe or unsubscribe~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id' => 'Trigger~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id+' => 'The trigger that fired the notification~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed' => 'Subscribed~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed+' => 'If the contact unsubscribed (no) or is subscribed (yes and default) to the notification~~',
]);

//
Expand Down Expand Up @@ -1201,4 +1218,8 @@
Dict::Add('CS CZ', 'Czech', 'Čeština', [
'Class:ResourceSystemMenu' => 'Resource System Menu~~',
'Class:ResourceSystemMenu+' => '',
'Class:EventNotification/Attribute:object_class' => 'Object class~~',
'Class:EventNotification/Attribute:object_class+' => 'Object class (Same as trigger)~~',
'Core:EventNotificationNewsroom:ErrorNotificationNotSent' => 'Notification not sent~~',
'Core:EventNotificationNewsroom:ErrorOnDBInsert' => 'An error occurred while saving the notification~~',
]);
23 changes: 22 additions & 1 deletion dictionaries/da.dictionary.itop.core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,24 @@
'Class:ActionNotification' => 'Notifikation',
'Class:ActionNotification+' => '',
'Class:ActionNotification/Attribute:language' => 'Language~~',
'Class:ActionNotification/Attribute:language+' => '~~',
'Class:ActionNotification/Attribute:language+' => 'Language to use for placeholders ($xxx$) inside the message (state, importance, priority, etc)~~',
]);

//
// Class: lnkActionNotificationToContact
//

Dict::Add('DA DA', 'Danish', 'Dansk', [
'Class:lnkActionNotificationToContact' => 'Link ActionNotification / Contact~~',
'Class:lnkActionNotificationToContact+' => 'Contact subscription to Notification Action~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id' => 'Contact~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id+' => 'Contact who subscribed (or not) to the notification~~',
'Class:lnkActionNotificationToContact/Attribute:action_id' => 'Action~~',
'Class:lnkActionNotificationToContact/Attribute:action_id+' => 'The notification that the contact received at least once, and to which he can subscribe or unsubscribe~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id' => 'Trigger~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id+' => 'The trigger that fired the notification~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed' => 'Subscribed~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed+' => 'If the contact unsubscribed (no) or is subscribed (yes and default) to the notification~~',
]);

//
Expand Down Expand Up @@ -1200,4 +1217,8 @@
Dict::Add('DA DA', 'Danish', 'Dansk', [
'Class:ResourceSystemMenu' => 'Resource System Menu~~',
'Class:ResourceSystemMenu+' => '',
'Class:EventNotification/Attribute:object_class' => 'Object class~~',
'Class:EventNotification/Attribute:object_class+' => 'Object class (Same as trigger)~~',
'Core:EventNotificationNewsroom:ErrorNotificationNotSent' => 'Notification not sent~~',
'Core:EventNotificationNewsroom:ErrorOnDBInsert' => 'An error occurred while saving the notification~~',
]);
19 changes: 18 additions & 1 deletion dictionaries/en.dictionary.itop.core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,24 @@
'Class:ActionNotification' => 'Notification Action',
'Class:ActionNotification+' => 'Notification Action (abstract)',
'Class:ActionNotification/Attribute:language' => 'Language',
'Class:ActionNotification/Attribute:language+' => '',
'Class:ActionNotification/Attribute:language+' => 'Language to use for placeholders ($xxx$) inside the message (state, importance, priority, etc)',
]);

//
// Class: lnkActionNotificationToContact
//

Dict::Add('EN US', 'English', 'English', [
'Class:lnkActionNotificationToContact' => 'Link ActionNotification / Contact',
'Class:lnkActionNotificationToContact+' => 'Contact subscription to Notification Action',
'Class:lnkActionNotificationToContact/Attribute:contact_id' => 'Contact',
'Class:lnkActionNotificationToContact/Attribute:contact_id+' => 'Contact who subscribed (or not) to the notification',
'Class:lnkActionNotificationToContact/Attribute:action_id' => 'Action',
'Class:lnkActionNotificationToContact/Attribute:action_id+' => 'The notification that the contact received at least once, and to which he can subscribe or unsubscribe',
'Class:lnkActionNotificationToContact/Attribute:trigger_id' => 'Trigger',
'Class:lnkActionNotificationToContact/Attribute:trigger_id+' => 'The trigger that fired the notification',
'Class:lnkActionNotificationToContact/Attribute:subscribed' => 'Subscribed',
'Class:lnkActionNotificationToContact/Attribute:subscribed+' => 'If the contact unsubscribed (no) or is subscribed (yes and default) to the notification',
]);

//
Expand Down
19 changes: 18 additions & 1 deletion dictionaries/en_gb.dictionary.itop.core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,24 @@
'Class:ActionNotification' => 'Notification Action',
'Class:ActionNotification+' => 'Notification Action (abstract)',
'Class:ActionNotification/Attribute:language' => 'Language',
'Class:ActionNotification/Attribute:language+' => '',
'Class:ActionNotification/Attribute:language+' => 'Language to use for placeholders ($xxx$) inside the message (state, importance, priority, etc)',
]);

//
// Class: lnkActionNotificationToContact
//

Dict::Add('EN GB', 'British English', 'British English', [
'Class:lnkActionNotificationToContact' => 'Link ActionNotification / Contact',
'Class:lnkActionNotificationToContact+' => 'Contact subscription to Notification Action',
'Class:lnkActionNotificationToContact/Attribute:contact_id' => 'Contact',
'Class:lnkActionNotificationToContact/Attribute:contact_id+' => 'Contact who subscribed (or not) to the notification',
'Class:lnkActionNotificationToContact/Attribute:action_id' => 'Action',
'Class:lnkActionNotificationToContact/Attribute:action_id+' => 'The notification that the contact received at least once, and to which he can subscribe or unsubscribe',
'Class:lnkActionNotificationToContact/Attribute:trigger_id' => 'Trigger',
'Class:lnkActionNotificationToContact/Attribute:trigger_id+' => 'The trigger that fired the notification',
'Class:lnkActionNotificationToContact/Attribute:subscribed' => 'Subscribed',
'Class:lnkActionNotificationToContact/Attribute:subscribed+' => 'If the contact unsubscribed (no) or is subscribed (yes and default) to the notification',
]);

//
Expand Down
25 changes: 23 additions & 2 deletions dictionaries/es_cr.dictionary.itop.core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,25 @@
Dict::Add('ES CR', 'Spanish', 'Español, Castellano', [
'Class:ActionNotification' => 'Notificación',
'Class:ActionNotification+' => 'Notificación (resúmen)',
'Class:ActionNotification/Attribute:language' => 'Language~~',
'Class:ActionNotification/Attribute:language+' => '~~',
'Class:ActionNotification/Attribute:language' => 'Idioma',
'Class:ActionNotification/Attribute:language+' => 'Idioma a utilizar para los marcadores de posición ($xxx$) dentro del mensaje (estado, importancia, prioridad, etc.)',
]);

//
// Class: lnkActionNotificationToContact
//

Dict::Add('ES CR', 'Spanish', 'Español, Castellano', [
'Class:lnkActionNotificationToContact' => 'Link ActionNotification / Contact~~',
'Class:lnkActionNotificationToContact+' => 'Contact subscription to Notification Action~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id' => 'Contact~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id+' => 'Contact who subscribed (or not) to the notification~~',
'Class:lnkActionNotificationToContact/Attribute:action_id' => 'Action~~',
'Class:lnkActionNotificationToContact/Attribute:action_id+' => 'The notification that the contact received at least once, and to which he can subscribe or unsubscribe~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id' => 'Trigger~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id+' => 'The trigger that fired the notification~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed' => 'Subscribed~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed+' => 'If the contact unsubscribed (no) or is subscribed (yes and default) to the notification~~',
]);

//
Expand Down Expand Up @@ -1188,4 +1205,8 @@
Dict::Add('ES CR', 'Spanish', 'Español, Castellano', [
'Class:ResourceSystemMenu' => 'Recurso Menú de Sistema',
'Class:ResourceSystemMenu+' => '',
'Class:EventNotification/Attribute:object_class' => 'Object class~~',
'Class:EventNotification/Attribute:object_class+' => 'Object class (Same as trigger)~~',
'Core:EventNotificationNewsroom:ErrorNotificationNotSent' => 'Notification not sent~~',
'Core:EventNotificationNewsroom:ErrorOnDBInsert' => 'An error occurred while saving the notification~~',
]);
19 changes: 18 additions & 1 deletion dictionaries/fr.dictionary.itop.core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,24 @@
'Class:ActionNotification' => 'Action de notification',
'Class:ActionNotification+' => '',
'Class:ActionNotification/Attribute:language' => 'Langue',
'Class:ActionNotification/Attribute:language+' => '',
'Class:ActionNotification/Attribute:language+' => 'Langue utilisée pour les placeholders ($xxx$) dans le message (statut, importance, priorité, etc)',
]);

//
// Class: lnkActionNotificationToContact
//

Dict::Add('FR FR', 'French', 'Français', [
'Class:lnkActionNotificationToContact' => 'Lien Action de Notification / Contact',
'Class:lnkActionNotificationToContact+' => 'Abonnement des contacts aux notifications',
'Class:lnkActionNotificationToContact/Attribute:contact_id' => 'Contact',
'Class:lnkActionNotificationToContact/Attribute:contact_id+' => 'Contact abonné à la notification',
'Class:lnkActionNotificationToContact/Attribute:action_id' => 'Action',
'Class:lnkActionNotificationToContact/Attribute:action_id+' => 'La notification à laquelle le contact est abonné',
'Class:lnkActionNotificationToContact/Attribute:trigger_id' => 'Déclencheur',
'Class:lnkActionNotificationToContact/Attribute:trigger_id+' => 'Le déclencheur à l\'origine de cette notification',
'Class:lnkActionNotificationToContact/Attribute:subscribed' => 'Abonné',
'Class:lnkActionNotificationToContact/Attribute:subscribed+' => 'Si le contact est abonné ou non à cette notification',
]);

//
Expand Down
23 changes: 22 additions & 1 deletion dictionaries/hu.dictionary.itop.core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,24 @@
'Class:ActionNotification' => 'Értesítés',
'Class:ActionNotification+' => 'Értesítés (absztrakt)',
'Class:ActionNotification/Attribute:language' => 'Language~~',
'Class:ActionNotification/Attribute:language+' => '~~',
'Class:ActionNotification/Attribute:language+' => 'Language to use for placeholders ($xxx$) inside the message (state, importance, priority, etc)~~',
]);

//
// Class: lnkActionNotificationToContact
//

Dict::Add('HU HU', 'Hungarian', 'Magyar', [
'Class:lnkActionNotificationToContact' => 'Link ActionNotification / Contact~~',
'Class:lnkActionNotificationToContact+' => 'Contact subscription to Notification Action~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id' => 'Contact~~',
'Class:lnkActionNotificationToContact/Attribute:contact_id+' => 'Contact who subscribed (or not) to the notification~~',
'Class:lnkActionNotificationToContact/Attribute:action_id' => 'Action~~',
'Class:lnkActionNotificationToContact/Attribute:action_id+' => 'The notification that the contact received at least once, and to which he can subscribe or unsubscribe~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id' => 'Trigger~~',
'Class:lnkActionNotificationToContact/Attribute:trigger_id+' => 'The trigger that fired the notification~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed' => 'Subscribed~~',
'Class:lnkActionNotificationToContact/Attribute:subscribed+' => 'If the contact unsubscribed (no) or is subscribed (yes and default) to the notification~~',
]);

//
Expand Down Expand Up @@ -1195,4 +1212,8 @@
Dict::Add('HU HU', 'Hungarian', 'Magyar', [
'Class:ResourceSystemMenu' => 'Erőforrás rendszer menü',
'Class:ResourceSystemMenu+' => '',
'Class:EventNotification/Attribute:object_class' => 'Object class~~',
'Class:EventNotification/Attribute:object_class+' => 'Object class (Same as trigger)~~',
'Core:EventNotificationNewsroom:ErrorNotificationNotSent' => 'Notification not sent~~',
'Core:EventNotificationNewsroom:ErrorOnDBInsert' => 'An error occurred while saving the notification~~',
]);
Loading