Feature/8994 add classes description #789
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipska
suggested changes
Dec 19, 2025
Contributor
Hipska
left a comment
Hipska
left a comment
There was a problem hiding this comment.
Great cleanup 👍 I do have a few minor suggestions.
datamodels/2.x/itop-config-mgmt/dictionaries/en.dict.itop-config-mgmt.php
Outdated
Show resolved
Hide resolved
| Dict::Add('EN US', 'English', 'English', [ | ||
| 'Class:Tablet' => 'Tablet', | ||
| 'Class:Tablet+' => '', | ||
| 'Class:Tablet+' => 'End user device. For example iPad, Galaxy Note/Tab Nexus, Kindle,...', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Class:Tablet+' => 'End user device. For example iPad, Galaxy Note/Tab Nexus, Kindle,...', | |
| 'Class:Tablet+' => 'End user device. For example iPad, Galaxy Note/Tab, Nexus, Kindle, …', |
| Dict::Add('EN US', 'English', 'English', [ | ||
| 'Class:NetworkDevice' => 'Network Device', | ||
| 'Class:NetworkDevice+' => '', | ||
| 'Class:NetworkDevice+' => 'Any type of network device: router, switch, hub, load balancer, firewall…', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Class:NetworkDevice+' => 'Any type of network device: router, switch, hub, load balancer, firewall…', | |
| 'Class:NetworkDevice+' => 'Any type of network device: router, switch, hub, load balancer, firewall, …', |
| 'Class:PhysicalInterface/Attribute:location_id' => 'Location id', | ||
| 'Class:PhysicalInterface/Attribute:location_id+' => '', | ||
| ]); | ||
| ]); |
…ig-mgmt.php Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
jbostoen
reviewed
Dec 23, 2025
| Dict::Add('EN US', 'English', 'English', [ | ||
| 'Class:Typology' => 'Typology', | ||
| 'Class:Typology+' => '', | ||
| 'Class:Typology+' => 'An abstract class. ExternalKeyAttribute to a Typology subclass are used in place of an EnumAttribute, to have more dynamic values', |
Contributor
There was a problem hiding this comment.
Attributes perhaps (plural)?
I'm not sure if this will make it much more clear to a standard iTop user though (someone who doesn't modify the data model).
jbostoen
reviewed
Dec 23, 2025
| Dict::Add('EN US', 'English', 'English', [ | ||
| 'Class:DocumentWeb' => 'Document Web', | ||
| 'Class:DocumentWeb+' => '', | ||
| 'Class:DocumentWeb+' => 'Hyperlinks to external applications or documents. Think to them as “pointers” to external documents. You cannot search in their content from '.ITOP_APPLICATION_SHORT, |
Contributor
There was a problem hiding this comment.
Think of them.
I'm also not sure the "French" quotes should be used here instead of regular ones ( " ).
jbostoen
reviewed
Dec 23, 2025
| Dict::Add('EN US', 'English', 'English', [ | ||
| 'Class:DocumentFile' => 'Document File', | ||
| 'Class:DocumentFile+' => '', | ||
| 'Class:DocumentFile+' => 'It\'s a type of Document which includes an '.ITOP_APPLICATION_SHORT.' uploaded file (in any format: Word, PDF, Spreadsheet, etc.). It can be used for all sorts of purpose: contract, sales order, datacenter maps, processing instructions, technical documentation.', |
Contributor
There was a problem hiding this comment.
I'd suggest to drop the ITOP_APPLICATION_SHORT here?
Also: "It can be used for different purposes:"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Symptom (bug) / Objective (enhancement)
Improve User understanding of the various iTop classes and their usage, by adding a description which is displayed as a tooltip when going above a Dashlet Badge of a class.
Proposed solution (bug and enhancement)
Checklist before requesting a review
Checklist of things to do before PR is ready to merge