N°8864 list extensions installation in setup recap #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odain-cbd
requested changes
Dec 29, 2025
| $aExtensionsAdded = []; | ||
| $aExtensionsRemoved = []; | ||
| $aExtensionsNotUninstallable = []; | ||
| foreach ($this->oExtensionsMap->GetAllExtensionsWithPreviouslyInstalled() as $oExtension) { |
Contributor
There was a problem hiding this comment.
could you extract all changes in a separate function? and cover it with tests?
| $this->oWizard->SetParameter('old_addon', true); | ||
| } | ||
|
|
||
| $aExtensionsAdded = []; |
Contributor
There was a problem hiding this comment.
the 2 arrays could contain html lines instead of extension codes. afterwhile you could use implode. code would be simpler.
| } elseif (!$oExtension->bInstalled && $bSelected) { | ||
| $aExtensionsAdded[$oExtension->sCode] = $oExtension->sLabel; | ||
| } | ||
| if (!$oExtension->CanBeUninstalled()) { |
Contributor
There was a problem hiding this comment.
no need to add uninstallable extensions when added. please move this 3 lines above.
| } | ||
| } | ||
|
|
||
| $sExtensionsAdded = '<ul><li>No extension added.</li></ul>'; |
Contributor
There was a problem hiding this comment.
this variable is initialized with a useless value when below array count >0.
| $sExtensionsAdded .= '</ul>'; | ||
| } | ||
|
|
||
| $sExtensionsRemoved = '<ul><li>No extension removed.</li></ul>'; |
Contributor
There was a problem hiding this comment.
same remark. this variable is initialized with a useless value when below array count >0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.