Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jan 17, 2026

Stop forcing NVIDIA PyTorch upgrades.

Users should control large PyTorch downloads and avoid surprise upgrades. This change removes the legacy torch mirror migration and stops treating NVIDIA cu130 minimum versions as a required package upgrade, so validation no longer triggers an automatic update. The package update flow also skips the recommended NVIDIA torch install step, keeping upgrades user-driven. Tradeoff: users can remain on older CUDA/torch builds and may hit compatibility issues; the NVIDIA driver warning still appears.

@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

Removes legacy NVIDIA PyTorch mirror migration and automatic upgrade calls: deletes migrateLegacyTorchMirrorIfNeeded, removes LEGACY_NVIDIA_TORCH_MIRROR/TorchMirrorUrl imports and special-case logic, and stops automatic ensureRecommendedNvidiaTorch invocation during package updates.

Changes

Cohort / File(s) Summary
ComfyInstallation changes
src/main-process/comfyInstallation.ts
Deleted private static migrateLegacyTorchMirrorIfNeeded(); removed LEGACY_NVIDIA_TORCH_MIRROR and TorchMirrorUrl imports; removed call to the migration from fromConfig() (-19 lines).
Virtual environment logic
src/virtualEnvironment.ts
Removed import of LEGACY_NVIDIA_TORCH_MIRROR; deleted special-case branch in fixDeviceMirrorMismatch() and removed NVIDIA upgrade check in hasRequirements (-9 lines).
Installation manager update flow
src/install/installationManager.ts
Removed automatic call to installation.virtualEnvironment.ensureRecommendedNvidiaTorch() from updatePackages; added comment to indicate automatic NVIDIA Torch upgrades are disabled (control flow now skips automatic upgrade).

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benceruleanlu benceruleanlu marked this pull request as ready for review January 17, 2026 21:52
@benceruleanlu benceruleanlu requested a review from a team as a code owner January 17, 2026 21:52
Copilot AI review requested due to automatic review settings January 17, 2026 21:52
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the automatic migration logic that was forcing users with legacy NVIDIA torch installations (CUDA 12.9) to upgrade to the newer CUDA 13.0 mirror. The change allows users to remain on their existing PyTorch versions instead of being automatically migrated.

Changes:

  • Removed automatic torch mirror migration from cu129 to cu130 for NVIDIA installations
  • Removed unused imports related to the legacy migration functionality
  • Removed the migrateLegacyTorchMirrorIfNeeded method and its invocation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/virtualEnvironment.ts Removed LEGACY_NVIDIA_TORCH_MIRROR import and auto-migration logic from fixDeviceMirrorMismatch function
src/main-process/comfyInstallation.ts Removed migrateLegacyTorchMirrorIfNeeded method, its invocation, and related imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 19, 2026
@benceruleanlu benceruleanlu changed the title Remove legacy torch mirror auto-migration Disable forced NVIDIA torch upgrades Jan 19, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 19, 2026
@christian-byrne christian-byrne merged commit 9f85660 into main Jan 20, 2026
16 of 17 checks passed
@christian-byrne christian-byrne deleted the chore/remove-torch-migration branch January 20, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants