-
Notifications
You must be signed in to change notification settings - Fork 184
Disable forced NVIDIA torch upgrades #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughRemoves legacy NVIDIA PyTorch mirror migration and automatic upgrade calls: deletes migrateLegacyTorchMirrorIfNeeded, removes LEGACY_NVIDIA_TORCH_MIRROR/TorchMirrorUrl imports and special-case logic, and stops automatic ensureRecommendedNvidiaTorch invocation during package updates. Changes
Possibly related PRs
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the automatic migration logic that was forcing users with legacy NVIDIA torch installations (CUDA 12.9) to upgrade to the newer CUDA 13.0 mirror. The change allows users to remain on their existing PyTorch versions instead of being automatically migrated.
Changes:
- Removed automatic torch mirror migration from cu129 to cu130 for NVIDIA installations
- Removed unused imports related to the legacy migration functionality
- Removed the
migrateLegacyTorchMirrorIfNeededmethod and its invocation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/virtualEnvironment.ts | Removed LEGACY_NVIDIA_TORCH_MIRROR import and auto-migration logic from fixDeviceMirrorMismatch function |
| src/main-process/comfyInstallation.ts | Removed migrateLegacyTorchMirrorIfNeeded method, its invocation, and related imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Stop forcing NVIDIA PyTorch upgrades.
Users should control large PyTorch downloads and avoid surprise upgrades. This change removes the legacy torch mirror migration and stops treating NVIDIA cu130 minimum versions as a required package upgrade, so validation no longer triggers an automatic update. The package update flow also skips the recommended NVIDIA torch install step, keeping upgrades user-driven. Tradeoff: users can remain on older CUDA/torch builds and may hit compatibility issues; the NVIDIA driver warning still appears.