Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jan 30, 2026

Ensure desktop source builds explicitly set GENERATE_SOURCEMAP=true when building the frontend so Sentry can resolve stack traces even if release zips omit maps.

Tests: yarn typecheck, yarn lint:check, yarn format, yarn lint

┆Issue is synchronized with this Notion page by Unito

Summary by CodeRabbit

  • Chores
    • Enhanced build configuration to enable source map generation for improved debugging and development processes.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 30, 2026 06:04
@benceruleanlu benceruleanlu requested a review from a team as a code owner January 30, 2026 06:04
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 30, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

This PR adds the GENERATE_SOURCEMAP: 'true' environment variable to the frontend build step in the build script, enabling source map generation during the build process without modifying any build logic or error handling.

Changes

Cohort / File(s) Summary
Frontend Build Configuration
scripts/downloadFrontend.js
Added GENERATE_SOURCEMAP: 'true' environment variable to the pnpm build invocation for source map generation during frontend build.

Possibly related PRs

  • Comfy-Org/desktop#1503: Also modifies environment variables passed to the frontend build in scripts/downloadFrontend.js by adding COREPACK_ENABLE_STRICT: '0'.
  • Comfy-Org/desktop#1502: Modifies the same build invocation in scripts/downloadFrontend.js, switching command execution to use pnpm.

Poem

🐰 A map for our sources, so clear and so bright,
Debug trails now visible, what a delight!
One simple variable, set to true,
Helps developers trace through the code they pursue.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: explicitly setting GENERATE_SOURCEMAP=true in the frontend build step for desktop builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/desktop-frontend-sourcemaps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures that frontend source builds for the desktop application explicitly enable sourcemap generation by setting GENERATE_SOURCEMAP=true as an environment variable during the build process. This allows Sentry to properly resolve stack traces from production builds even when release artifacts omit the source maps.

Changes:

  • Added GENERATE_SOURCEMAP: 'true' environment variable to the frontend build command when building from source

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants