feat(commitment_marketplace): cannot-buy-own-listing-additional-edge-cases-and-fuzz-inputs#459
Merged
1nonlypiece merged 4 commits intoCommitlabs-Org:masterfrom Apr 1, 2026
Conversation
…cases-and-fuzz-inputs
|
@Tijesunimi004 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the commitment_marketplace Soroban contract to tighten “cannot buy/offer on own listing” edge cases and to use shared safe-math helpers in fee calculations.
Changes:
- Add self-owned listing/auction checks to
make_offerand a self-offer guard toaccept_offer. - Replace fee arithmetic in
buy_nft,accept_offer, andend_auctionwithshared_utils::math::SafeMath. - Add tests covering the new self-owned offer/accept edge cases.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
contracts/commitment_marketplace/src/lib.rs |
Adds self-owned offer checks; switches fee computation to SafeMath; adds overflow-safe ends_at calculation. |
contracts/commitment_marketplace/src/tests.rs |
Adds new panic-assertion tests for self-owned listing/auction offer cases. |
contracts/commitment_marketplace/Cargo.toml |
Adds a path dependency on shared_utils. |
Cargo.lock |
Updates lockfile to include shared_utils dependency for the marketplace crate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…own-listing-additional-edge-cases-and-fuzz-inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273. Added checks and SafeMath integrations to mitigate integer overflows and prevent purchasing or offering on self-owned listings.