Skip to content

Conversation

@ruhan1
Copy link
Contributor

@ruhan1 ruhan1 commented Dec 11, 2025

Add validation to ensure filenames follow Maven naming convention (artifactId-version-...) and reject paths where the regex matches but produces incorrect parsing results. This prevents mis-parsing of non-standard paths like RPM artifacts that don't conform to Maven layout.

🤖 Generated with Claude Code

@ruhan1 ruhan1 requested review from pkocandr, rnc and sswguo December 11, 2025 03:59
Copy link
Contributor

@pkocandr pkocandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably remove the redhat suffix from the example path used in the test, but otherwise it looks to fix the issue we currently have.

Add validation to ensure filenames follow Maven naming convention
(artifactId-version-...) and reject paths where the regex matches but
produces incorrect parsing results. This prevents mis-parsing of
non-standard paths like RPM artifacts that don't conform to Maven layout.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@ruhan1 ruhan1 force-pushed the fix-artifact-path-nonstandard-validation branch from 373d276 to d4331a6 Compare December 12, 2025 01:30
@ruhan1
Copy link
Contributor Author

ruhan1 commented Dec 12, 2025

I would probably remove the redhat suffix from the example path used in the test, but otherwise it looks to fix the issue we currently have.

Agree and removed.

@ruhan1 ruhan1 merged commit c7f745d into Commonjava:master Dec 12, 2025
1 check passed
@ruhan1 ruhan1 deleted the fix-artifact-path-nonstandard-validation branch December 12, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants