Add Proxy Site cache support for squid proxy delivery #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sswguo
reviewed
Jan 20, 2025
| doProxy = true; | ||
| } | ||
| // if the site is not in memory, query db through isProxySite | ||
| else if ( isProxySite( site ) ) |
Member
There was a problem hiding this comment.
For those sites already in the whitelist, this will check it every request, right ? it's better to avoid that if it's the case.
Member
Author
There was a problem hiding this comment.
@sswguo yeah, that's the point. I'll try to add another mem cache for whitelist, and any first successful request going to the site without proxy will add into it, the following access on this whitelist site will check the mem cache instead to avoid frequent db query.
I'm doing refactor on Commonjava/path-mapped-storage#121, will amend this point together.
Member
Author
|
Close this and will commit new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.