Open
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1221Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1221" |
|
What's the process with failing CI checks? Does someone restart them? The changes look good to me. The settings file is the old format, we should update the skill to generate the new one, but it's still valid. |
davidfowl
reviewed
Mar 20, 2026
| "appHostPath": "../apphost.ts", | ||
| "language": "typescript/nodejs", | ||
| "packages": { | ||
| "CommunityToolkit.Aspire.Hosting.Java": "" |
Contributor
There was a problem hiding this comment.
This doesn't work outside of the aspire repo. This needs to be a project reference.
There was a problem hiding this comment.
Bad skill that was made for our repos :/
Contributor
|
I gotta ask, why Java first? Why not all of the other database integrations. |
Contributor
Author
@davidfowl - I did all of them: https://github.com/CommunityToolkit/Aspire/issues?q=is%3Apr+is%3Aopen+author%3AIEvangelist |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
IEvangelist
force-pushed
the
dapine/polyglot-export-java
branch
from
eb5d108 to
6487997
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for java.