merge attempt #5 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed a bug in famous where transform would report changed when it was not and vise versa. * Fixed a bug in famous engine where only every even child would get removed because a loop was iterating the list while it was being truncated in each step. * Note: I've made an assumption that worldtransforms does not need to be updated every frame. this.calculatingWorldMatrix = true has been commented out in Transform.prototype.setBreakPoint. I don't know if this is correct, nor do I know what those breakpoints are, but I think everything was flagged as breakpoints, so just commenting out that line helped me. There is probably some more correct fix for this.
The problem, massive amount of drawcommands being sent each frame, happens if DomElement.OnDismount is called and this.setCutoutState(false); happens. This call seem to be to turn off this cutout thing, but in my case it was never turned on. Anyway, it causes som webgl content to be created, just so it can set that flag to off. And in turn that causes the barrage of drawcommands. So this fix is hackish in the sense that it stops context._initWebGLRenderer(); from happening, and does not adress the real problem, whatever that is..
…y do it's things when some changes has happened. This save 12 ms on ipad2 when you have 1000 elements to go through.
Fixed it by refreshing all child transforms when a node is refreshed. Similar to what I did for the opacity system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.