Scaled evals #159
Open
Scaled evals #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR scales evaluations by updating dependencies and modifying the deepspeed accelerate configuration for vllm-based eval scripts.
- Added additional dependencies (setuptools, ipykernel, matplotlib) in pyproject.toml.
- Increased num_processes and added main_process_port in the deepspeed configuration file.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Added dependencies to support additional functionality. |
| benchmarks/ppo/accelerate_configs/deepspeed_zero2.yaml | Updated parallel process count and added a process port setting. |
Files not reviewed (2)
- jobs/validate_all_static.sh: Language not supported
- jobs/validate_all_static_diversity.sh: Language not supported
Jacob-Chmura
requested changes
Apr 30, 2025
jobs/validate_all_static.sh
Outdated
|
|
||
| # list all sub‐tasks | ||
| tasks=( | ||
| ultra-hh-sampled |
Member
There was a problem hiding this comment.
Why don't we no longer need the full lest of datasets as it was before? The loop is much better, just trying to understand why the change
Member
There was a problem hiding this comment.
Should these changes be propogated to the other benchmark deepspeed configs?
Member
There was a problem hiding this comment.
Are the dependency changes temporary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a few new scripts to run eval with vllm.