Skip to content

Remove selfregistering from pypicongpu#5654

Merged
ikbuibui merged 5 commits intoComputationalRadiationPhysics:devfrom
chillenzer:remove-selfregistering-from-pypicongpu
Mar 12, 2026
Merged

Remove selfregistering from pypicongpu#5654
ikbuibui merged 5 commits intoComputationalRadiationPhysics:devfrom
chillenzer:remove-selfregistering-from-pypicongpu

Conversation

@chillenzer
Copy link
Copy Markdown
Contributor

@chillenzer chillenzer commented Mar 11, 2026

This PR removes the SelfRegistering infrastructure in favour of a type_...: Literal[True] = True member in each class that needs to communicate its type into the context. By mustache standard a missing variable is just treated as an empty string allowing us to do logic via {{#type_...}}.

With the previous configuration of chevron (the mustache rendering library we used), this would have led to a ton of errors. I've switch to moosetash which allows more fine-grained control.

Closes #5567 as an aside.

This PR furthermore fixes a bug in the generation of the dependency matrix that dropped some specs.

@chillenzer chillenzer added this to the 0.9.0 / next stable milestone Mar 11, 2026
@chillenzer chillenzer requested a review from ikbuibui March 11, 2026 13:33
@chillenzer chillenzer added CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests PICMI pypicongpu and picmi related labels Mar 11, 2026
@chillenzer chillenzer force-pushed the remove-selfregistering-from-pypicongpu branch from 824e3ef to b70f99b Compare March 11, 2026 14:47
@chillenzer chillenzer marked this pull request as ready for review March 11, 2026 14:48
@chillenzer
Copy link
Copy Markdown
Contributor Author

The CI failures are the ones that I have opened bug fixes for in moosetash (see here). But the pip install command seems to ignore the custom git version I'm supplying and pulls the mainline version. I'll investigate tomorrow.

@chillenzer chillenzer force-pushed the remove-selfregistering-from-pypicongpu branch 3 times, most recently from f0c7ddb to 9132ed1 Compare March 12, 2026 08:47
@chillenzer chillenzer force-pushed the remove-selfregistering-from-pypicongpu branch from 9132ed1 to 1c724ff Compare March 12, 2026 09:36
@ikbuibui ikbuibui merged commit 2fee07e into ComputationalRadiationPhysics:dev Mar 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:no-compile CI is skipping compile/runtime tests but runs PICMI tests PICMI pypicongpu and picmi related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken gridDist in PICMI

2 participants