Remove selfregistering from pypicongpu#5654
Merged
ikbuibui merged 5 commits intoComputationalRadiationPhysics:devfrom Mar 12, 2026
Merged
Remove selfregistering from pypicongpu#5654ikbuibui merged 5 commits intoComputationalRadiationPhysics:devfrom
ikbuibui merged 5 commits intoComputationalRadiationPhysics:devfrom
Conversation
824e3ef to
b70f99b
Compare
Contributor
Author
|
The CI failures are the ones that I have opened bug fixes for in |
f0c7ddb to
9132ed1
Compare
9132ed1 to
1c724ff
Compare
ikbuibui
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
SelfRegisteringinfrastructure in favour of atype_...: Literal[True] = Truemember in each class that needs to communicate its type into the context. By mustache standard a missing variable is just treated as an empty string allowing us to do logic via{{#type_...}}.With the previous configuration of
chevron(the mustache rendering library we used), this would have led to a ton of errors. I've switch to moosetash which allows more fine-grained control.Closes #5567 as an aside.
This PR furthermore fixes a bug in the generation of the dependency matrix that dropped some specs.