fix: execute template in expandAlias for -a flag#4
Merged
datamuc merged 3 commits intoConSol-Monitoring:mainfrom May 8, 2026
Merged
fix: execute template in expandAlias for -a flag#4datamuc merged 3 commits intoConSol-Monitoring:mainfrom
datamuc merged 3 commits intoConSol-Monitoring:mainfrom
Conversation
The expandAlias function was parsing the template but never executing it,
resulting in empty output when using the -a (alias) flag with template syntax.
Now properly executes the template with the label map and handles execution
errors by falling back to the original alias string.
Fixes alias templates like:
- check_prometheus m q -a 'Host: {{.hostname}}'
- check_prometheus m q -a 'Status: {{if eq .xvalue "1"}}UP{{else}}DOWN{{end}}'
Includes comprehensive unit tests covering:
- Simple label substitution
- Multiple labels
- xvalue special variable
- Conditional logic (if/else)
- Invalid template fallback
Include internal mode in test command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expandAlias function was parsing the template but never executing it, resulting in empty output when using the -a (alias) flag with template syntax. Now properly executes the template with the label map and handles execution errors by falling back to the original alias string.
Fixes alias templates like:
Includes comprehensive unit tests covering: