Skip to content

Upgrade baton-sdk to v0.7.4 and Go to 1.25.2#29

Open
gontzess wants to merge 3 commits intomainfrom
task-sdk-upgrade-batch-5
Open

Upgrade baton-sdk to v0.7.4 and Go to 1.25.2#29
gontzess wants to merge 3 commits intomainfrom
task-sdk-upgrade-batch-5

Conversation

@gontzess
Copy link

@gontzess gontzess commented Jan 27, 2026

Summary

  • Upgrade baton-sdk to v0.7.4
  • Upgrade Go to 1.25.2
  • Add config generation with go generate following baton-datadog pattern
  • Update Makefile with GENERATED_CONF, BUILD_TAGS, and generate target
  • Migrate from viper to typed config struct
  • Fix lint issue: use fmt.Fprintf instead of WriteString(fmt.Sprintf())

CI Status

  • go-lint: ✅ Pass
  • go-test: ✅ Pass

🤖 Generated with Claude Code

@gontzess gontzess requested a review from a team January 27, 2026 16:43
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Warning

Rate limit exceeded

@gontzess has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.


Comment @coderabbitai help to get the list of available commands and usage tips.

@gontzess gontzess changed the title Upgrade baton-sdk to v0.7.3 and Go to 1.25.2 Upgrade baton-sdk to v0.7.4 and Go to 1.25.2 Jan 27, 2026
@gontzess gontzess marked this pull request as draft January 27, 2026 18:59
@gontzess gontzess force-pushed the task-sdk-upgrade-batch-5 branch 2 times, most recently from 5cac6ef to 7370e36 Compare January 27, 2026 20:31
@gontzess gontzess force-pushed the task-sdk-upgrade-batch-5 branch from 7370e36 to 2d7753d Compare January 27, 2026 21:20
- Add pkg/config with field definitions and go generate directive
- Remove old cmd/baton-retool/config.go (moved to pkg/config)
- Update Makefile with GENERATED_CONF, BUILD_TAGS, and generate target
- Update main.go to use generated config struct instead of viper

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gontzess gontzess marked this pull request as ready for review January 27, 2026 22:48
Add connectorrunner.WithDefaultCapabilitiesConnectorBuilder to enable
automatic capability detection from connector interface implementation.

args = append(args, limit+1)
_, _ = sb.WriteString(fmt.Sprintf("LIMIT $%d ", len(args)))
fmt.Fprintf(sb, "LIMIT $%d ", len(args))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these changes for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing linting. All these upgrades come with a big lint version bump too and more stringent rules

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes the PR description includes this: Fix lint issue: use fmt.Fprintf instead of WriteString(fmt.Sprintf())

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes the PR description includes this: Fix lint issue: use fmt.Fprintf instead of WriteString(fmt.Sprintf())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants