Create streaming client for entitlements list endpoint#464
Create streaming client for entitlements list endpoint#464loganintech wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
Bug: Stream Reuse Causes Sync Failures
The entitlementStreamer is reused across multiple resource syncs, which can lead to request/response mismatches on the bidirectional stream. If Send() or Recv() encounters a non-EOF error, the stream isn't reset, leaving it in a broken state for subsequent calls and causing sync failures.
There was a problem hiding this comment.
Noted, I need to close send on the clients when we exit a sync. In truth, I don't think this is going to end up working at all. We could re-write baton-sdk entirely to be streamified from top to bottom but that's not the world we live in currently.
No description provided.