Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Comment |
|
|
||
| option go_package = "github.com/conductorone/baton-sdk/pb/c1/connector/v2"; | ||
|
|
||
| message IdAlias { |
There was a problem hiding this comment.
Is this for a resource, an entitlement, a grant, or all of them? If it's just for one, maybe it can have a name like ResourceAlias and go in annotation_resource.proto.
Also should this have another attribute saying what type of alias it is? eg: ARN, URL, resource id, etc. That attribute could be a string or an enum depending on how you want to use it on the C1 side.
b465403 to
d4e3780
Compare
| } | ||
|
|
||
| message Aliases { | ||
| repeated IdAlias id = 1; |
There was a problem hiding this comment.
why this one is an array? I think one resource should have one alias? right?
d4e3780 to
71c4c7e
Compare
No description provided.