Skip to content

(WIP) Add id alias#638

Draft
MarcusGoldschmidt wants to merge 2 commits intomainfrom
goldschmidt/id-alias
Draft

(WIP) Add id alias#638
MarcusGoldschmidt wants to merge 2 commits intomainfrom
goldschmidt/id-alias

Conversation

@MarcusGoldschmidt
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch goldschmidt/id-alias

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Comment @coderabbitai help to get the list of available commands and usage tips.


option go_package = "github.com/conductorone/baton-sdk/pb/c1/connector/v2";

message IdAlias {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for a resource, an entitlement, a grant, or all of them? If it's just for one, maybe it can have a name like ResourceAlias and go in annotation_resource.proto.

Also should this have another attribute saying what type of alias it is? eg: ARN, URL, resource id, etc. That attribute could be a string or an enum depending on how you want to use it on the C1 side.

@MarcusGoldschmidt MarcusGoldschmidt changed the title add id alias (WIP) Add id alias Jan 26, 2026
}

message Aliases {
repeated IdAlias id = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this one is an array? I think one resource should have one alias? right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants