Emit HTTP cache hit/miss as metrics instead of logs#656
Open
Emit HTTP cache hit/miss as metrics instead of logs#656
Conversation
Replace debug log statements for cache hits and misses with OpenTelemetry metrics. Add WithMetricsHandler option to BaseHttpClient to enable metric recording when a metrics handler is provided. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughThe PR introduces metrics integration for HTTP cache events in the HTTP client wrapper. A metrics handler option is added to configure metrics collection, with helper methods to emit cache hit and miss metrics during cache operations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
ggreer
reviewed
Feb 2, 2026
| baseHttpCache icache | ||
| HttpClient *http.Client | ||
| rateLimiter uRateLimit.Limiter | ||
| baseHttpCache icache |
Contributor
There was a problem hiding this comment.
Would it make more sense to put the metrics handler on the cache itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithMetricsHandleroption toBaseHttpClientto enable metric recordingbaton_sdk.http_cache_hitandbaton_sdk.http_cache_missTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.