Open
Conversation
WalkthroughThe PR upgrades Go toolchain and multiple dependencies (notably github.com/conductorone/baton-sdk), removes redundant blank imports across connector files, updates resource call sites to use sdkResources, and changes a CreateAccount parameter type and adds a static interface assertion in server_user.go. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
ba23f57 to
046abf5
Compare
5f8d91c to
519671c
Compare
519671c to
88baa0c
Compare
Updates the CreateAccount method signature to use v2.LocalCredentialOptions instead of the deprecated v2.CredentialOptions, which was causing an "old account manager interface implemented" error after the SDK upgrade to v0.7.4. Also adds compile-time verification that userPrincipalSyncer implements the AccountManagerLimited interface.
johnallers
approved these changes
Jan 28, 2026
btipling
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI Status
Test plan
Summary by CodeRabbit
Dependencies
Chores
✏️ Tip: You can customize this high-level summary in your review settings.