Conversation
| return text.contains("${" + key + "}"); | ||
| } | ||
|
|
||
| public static Map<PropertyKey, String> resolveTextSubstitutions(final Map<PropertyKey, Property> resolved, |
There was a problem hiding this comment.
I am only concerned with the amount of extra work this is doing to handle things that refer to eachother. We've been dealing with performance issues and would like to potentially limit the amount of work necessary to resolve a file. This seems like it is adding a significant amount of work to solve a case that can be solved by not having configurations bidirectional. I'm curious on Edin's point of view here.
| <groupId>ConfigHub</groupId> | ||
| <artifactId>ConfigHub-Core</artifactId> | ||
| <version>1.8.4</version> | ||
| <version>1.8.5-alpha-1</version> |
There was a problem hiding this comment.
we probably don't want to change the base version master to the alpha. I get you probably did this to get a build for yourself.
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.16.20</version> | ||
| <version>1.18.4</version> |
There was a problem hiding this comment.
i agree with updating things, but it is subtle and not described in this commit message.
2 participants
Additional step during properties retrieval that resolves dependencies between them (in form "key0": "val0", "key1": "${key0}").