Fix bug where two decimal numbers added give wrong output

assets/services/assets-api/src/modules/v2Partition/partition.service/index.ts

@@ -13,6 +13,7 @@ import {
 } from 'src/types/token';
 import { hexaToASCII, ASCIIToHexa } from 'src/utils/hex';
 import { checkSolidityBytes32 } from 'src/utils/solidity';
+import { addNumbersByConvertingIntoBigNumber } from "src/utils/number";
 
 @Injectable()
 export class PartitionService {
@@ -281,10 +282,9 @@ export class PartitionService {
           partitionClass
         ].reduce((supply: number, currentAssetState: AssetStateOnChainData) => {
           return (
-            supply +
-            currentAssetState[
+            addNumbersByConvertingIntoBigNumber(supply, currentAssetState[
               TokenKeys.ASSET_CLASSES_ON_CHAIN_STATES_TOTAL_SUPPLY
-            ]
+            ])
           );
         }, 0);
         const assetClassOnChainData: AssetClassOnChainData = {

assets/services/assets-api/src/modules/v2Token/token.service/index.ts

@@ -51,6 +51,7 @@ import {
   DocumentKeys,
   GeneralDataKeys,
 } from 'src/types/asset';
+import { addNumbersByConvertingIntoBigNumber } from "src/utils/number";
 
 const funderAddress: string = process.env.FUNDER_ADDRESS;
 
@@ -427,8 +428,9 @@ export class TokenHelperService {
           ? assetClassesOnChainData.reduce(
               (supply: number, assetClassData: AssetClassOnChainData) => {
                 return (
-                  supply +
-                  assetClassData[TokenKeys.ASSET_CLASSES_ON_CHAIN_TOTAL_SUPPLY]
+                  addNumbersByConvertingIntoBigNumber(supply, assetClassData[
+                    TokenKeys.ASSET_CLASSES_ON_CHAIN_STATES_TOTAL_SUPPLY
+                  ])
                 );
               },
               0,

assets/services/assets-api/src/utils/number.ts

@@ -6,7 +6,7 @@ export const MAX_SUPPORTED_INTEGER = 1000000000000000;
 export const MIN_SUPPORTED_INTEGER = 0;
 
 /**
- * Function if integer is not to big in order to avoid 'overflow' in database
+ * Function if integer is not too big in order to avoid 'overflow' in database
  */
 export const checkIntegerFormat = (
   quantity: number,
@@ -95,3 +95,30 @@ export const addDecimalsAndConvertToHex = (number, decimals): string => {
     throw new Error(`addDecimalsAndConvertToHex --> ${error.message}`);
   }
 };
+
+/**
+ * [Add Numbers By Converting Into BigNumber]
+ *
+ * The purpose of this function is to add numbers after converting
+ * them to BigNumber and then return the Number
+ *
+ * This function is used everytime we add two numbers.
+ *
+ */
+export const addNumbersByConvertingIntoBigNumber = (number1, number2): number => {
+  try {
+    const number1Bn = new BigNumber(number1);
+    const number2Bn = new BigNumber(number2);
+    const sumBn = number1Bn.plus(number2Bn);
+    return parseFloat(sumBn.toString());
+  } catch (error) {
+    ErrorService.logAndThrowFunctionError(
+      error,
+      `Failed to add numbers ${number1} and ${number2} by converting to BigNumber first`,
+      'addNumbersByConvertingIntoBigNumber',
+      false,
+      500,
+    );
+    throw new Error(`addNumbersByConvertingIntoBigNumber --> ${error.message}`);
+  }
+};