Fix concurrency issue on LocalNodeRecordStore #191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
May 14, 2025
| recordStore.onCustomFieldValueChanged("fieldName", Bytes.fromHexString("0x111111")); | ||
|
|
||
| // No updates propagated to listener | ||
| assertThat(listenerCalls).hasSize(0); |
Nashatyrev
reviewed
May 14, 2025
| if (!record.equals(oldRecord)) { | ||
| recordListener.recordUpdated(oldRecord, record); | ||
| newRecord -> { | ||
| final NodeRecord oldRecord = latestRecord.getAndSet(newRecord); |
Contributor
There was a problem hiding this comment.
Does it still look as non-atomic update here? get and getAndSet are not under lock and the value can be modified between these calls.
Member
Author
There was a problem hiding this comment.
Haven't looked into this again. Busy getting PeerDAS into master :)
Will have a second look soon!
Member
Author
|
Gonna revisit this one soon! Had a better idea :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
fixes #190