graphics: fall back to GDI when DirectDraw isn't available or failed to init#3
Open
mrpapersonic wants to merge 2 commits intoConspiracyHu:mainfrom
Open
graphics: fall back to GDI when DirectDraw isn't available or failed to init#3mrpapersonic wants to merge 2 commits intoConspiracyHu:mainfrom
mrpapersonic wants to merge 2 commits intoConspiracyHu:mainfrom
Conversation
mrpapersonic
commented
Aug 3, 2025
| <ConfigurationType>Application</ConfigurationType> | ||
| <UseDebugLibraries>false</UseDebugLibraries> | ||
| <PlatformToolset>v143</PlatformToolset> | ||
| <PlatformToolset>v142</PlatformToolset> |
Author
There was a problem hiding this comment.
this line can be reverted back to v143, vs2019 doesn't have toolset v143..
thanks microsoft, very cool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates the graphics class into different subclasses as well, with windows-specific things in one class that both GDI and directdraw inherit from, etc.
Also removes the explicit directdraw library dependency by loading it in at runtime.