Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| class URLSessionLogger { | ||
| static var runningSpans = [String: Span]() | ||
| static var runningSpansQueue = DispatchQueue(label: "io.opentelemetry.URLSessionLogger") |
There was a problem hiding this comment.
Unused static variables in non-Darwin URLSessionLogger stub
Low Severity
The non-Darwin stub of URLSessionLogger declares runningSpans and runningSpansQueue static variables, but they are never used. The stub methods (processAndLogRequest, logResponse, logError) are all no-ops that don't access these variables. The corresponding URLSessionInstrumentation.startedRequestSpans on non-Darwin also returns [] directly without using these.
|
|
||
| public var version: String { | ||
| let version = ProcessInfo.processInfo.operatingSystemVersion | ||
| return "\(version.majorVersion).\(version.minorVersion).\(version.patchVersion)" |
There was a problem hiding this comment.
Duplicated code between Darwin and non-Darwin implementations
Low Severity
The description and version computed properties have identical implementations in both Darwin (lines 19-20, 37-40) and non-Darwin (lines 48-50, 60-62) versions of OperatingSystemDataSource. Both use name + " " + ProcessInfo.processInfo.operatingSystemVersionString for description and the same ProcessInfo.processInfo.operatingSystemVersion formatting for version.
1 participant
Attempt to get dependabot to work by having darwin only targets compile for linux