Link your codeforces profile with cli #26

ashutoshsuthar2020 · 2022-10-10T19:58:11Z

Added a profile command which allows you to make profile card of the given user
For example

ecp profile tourist
---------------------
User Name : GennadyKorotkevich
Rating : 3834
Contribution : 134
Rank : legendary grandmaster
Max Rating : 3979
---------------------

akstron · 2022-10-11T05:43:17Z

Kindly provide description for each PR you raise.

akstron · 2022-10-11T10:24:41Z

By linking I mean that we can store current user info somewhere. Your are able to display some random user as of now. Can we store that so that we can use this info somewhere in other commands. Also, I think that this command should be included in config command group. Kindly put your arguments of creating a new command group of it.

ashutoshsuthar2020 · 2022-10-11T15:37:47Z

Sir please check now i have created function to save and fetch data about user in config file

akstron · 2022-10-11T15:56:23Z

src/Config/Config.py

+            config["firstname"] = html_content["result"][0]["firstName"]
+            config["lastname"] = html_content["result"][0]["lastName"]
+            config["rating"] = str(html_content["result"][0]["rating"]),
+            config["contri"] = str(html_content["result"][0]["contribution"]),
+            config["rank"] = str(html_content["result"][0]["rank"]),
+            config["maxrating"] = str(html_content["result"][0]["maxRating"])


We can create a single object with name profile, and put above as key value pairs, and then write that object.

akstron · 2022-10-11T15:57:29Z

COMMANDS.md

+*   ```
+    ecp config set_user <username>
+    ```


Shouldn't it be 'set-user' instead of 'set_user'?

ashutoshsuthar2020 · 2022-10-11T16:15:05Z

Have made the recommended changes

akstron · 2022-10-12T13:19:29Z

Kindly add proxy support to it.

ashutoshsuthar2020 · 2022-10-12T13:47:35Z

src/Cli/config.py have called request from self.get_proxy() ,and it works properly.

akstron · 2022-10-12T14:05:00Z

src/Config/Config.py

            config_file.write(json.dumps(config))
+
+    def set_user(self, user):
+        response = requests.get(url='http://codeforces.com/api/user.info?handles='+user,proxies=self.get_proxy())


We can store the url in a variable first and then use it to improve readability

Not done yet

ashutoshsuthar2020 · 2022-10-12T17:38:43Z

done

akstron · 2022-10-13T10:35:54Z

src/Cli/config.py

+    try:
+        config = Config()
+        config.get_user()


It's not printing anything

corrected it

akstron · 2022-10-13T10:36:41Z

src/Config/Config.py

+        address='http://codeforces.com/api/user.info?handles='+user
+        response = requests.get(url=address,proxies=self.get_proxy())
+        if(response.status_code!=200):
+            raise UsernameError('User not Found')


No implementation of UsernameError class. Also I think "UsernameNotFound" would be a better name

akstron · 2022-10-14T05:40:02Z

src/Cli/config.py

    try:
        config = Config()
-        config.get_user()
+        print(config.get_user())


Use click.echo with styling.

akstron · 2022-10-14T05:42:35Z

src/Config/Config.py

        response = requests.get(url=address,proxies=self.get_proxy())
        if(response.status_code!=200):
-            raise UsernameError('User not Found')
+            raise UsernameError('UsernameNotFound')


I was saying that there is no such class as "UsernameError". You have to create it on your own. Also I think the name of class should be "UsernameNotFound" with error string as "User not found".

akstron · 2022-10-14T11:58:37Z

src/Config/Config.py

+class UsernameNotFound(Exception):
+    def __init__(self, msg):
+        super().__init__(self, msg)


In the previous review as well I said shouldn't it have a default msg = "User not found"?
Also, kindly make a separate directory for exceptions related to profile and write class over there. Look into "Runner" directory, you can find an example there.

sir please check the changes now.

akstron · 2022-10-16T11:07:32Z

When using "get-user" we can raise an exception when user is not set earlier.

ashutoshsuthar2020 · 2022-10-16T11:18:07Z

When using "get-user" we can now raise an exception when user is not set earlier.

akstron · 2022-10-16T16:44:46Z

src/Config/Config.py

+        with open(config_file_path, 'r') as config_file:
+            config = json.load(config_file)
+        if(len(config["user"]["firstname"])==0):
+            raise UserNotSet


Are you not testing your commands after writing code?? Why raising a class??

Also, put proper spacing between functions and wherever you find it necessary.

and fixed error HTTPSConnectionPool(host='codeforces.com', port=443): Max retries exceeded with url: /api/user.info?handles=touris (Caused by ProxyError('Your proxy appears to only use HTTP and not HTTPS, try changing your proxy URL to be HTTP. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#https-proxy-error-http-proxy', SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1129)'))))

ashutoshsuthar2020 · 2022-10-18T14:09:39Z

Sir please check the changes made now.

akstron · 2022-10-18T17:59:10Z

Receiving a proxy authentication error. Are you facing the same problem?

reference : https://stackoverflow.com/questions/28521535/requests-how-to-disable-bypass-proxy

ashutoshsuthar2020 · 2022-10-18T18:24:28Z

It was due to an update in the requests library, I have made the necessary changes.

akstron · 2022-10-20T13:57:33Z

src/Cli/config.py

+        config = Config()
+        print(config.get_user())


Probably overwritten by some new commit. Use click.echo here. Also, consider formatting this instead of simply printing the object.

akstron · 2022-10-20T13:58:37Z

src/Config/exceptions/UserNotSet.py

@@ -0,0 +1,3 @@
+class UserNotSet(Exception):
+    def __init__(self) -> None:
+        super().__init__("User not set yet.")


No need of full stop

akstron · 2022-10-20T13:59:40Z

src/Cli/config.py

+        click.echo(e)
+


Can use click styling to change color to red

akstron · 2022-10-20T14:00:24Z

src/Config/config.json

@@ -1 +1 @@
-{"test_in_progress": "False", "language": "python", "template": "D:\\Alok country\\Apun coder banega\\Projects\\CP-CLI\\test\\code.cpp", "proxy": ""}
+{"user": {"firstname": "", "lastname": "", "rating": [""], "contri": [""], "rank": [""], "maxrating": ""}, "test_in_progress": "False", "language": "python", "template": "D:\\Alok country\\Apun coder banega\\Projects\\CP-CLI\\test\\code.cpp", "proxy": ""}


Why storing rating, contri, rank and maxrating in an array?

it will get easier if we call get-user method anywhere else in the code

I don't get it. How come it will become easier?

I just tried to encapsulate user in one key value pair.
I thought it be easier to call property of user from this key value pair, instead of calling individual properties of user

It's a good approach. Probably you are not getting my question. What I an asking is why is your rating property in user object an array? As you can see it's written that "rating": [""]. Why this instead of "rating" : "".

I had the same doubt actually, when I call it, it comes in this form only.

ashutoshsuthar2020

Applied recommended changes

ashutoshsuthar2020 · 2022-10-13T14:06:22Z

src/Cli/config.py

+    try:
+        config = Config()
+        config.get_user()


corrected it

ashutoshsuthar2020 · 2022-10-14T08:44:32Z

src/Config/Config.py

        response = requests.get(url=address,proxies=self.get_proxy())
        if(response.status_code!=200):
-            raise UsernameError('User not Found')
+            raise UsernameError('UsernameNotFound')


ashutoshsuthar2020 · 2022-10-14T17:03:56Z

src/Config/Config.py

+class UsernameNotFound(Exception):
+    def __init__(self, msg):
+        super().__init__(self, msg)


sir please check the changes now.

ashutoshsuthar2020 · 2022-10-20T14:47:42Z

src/Config/config.json

@@ -1 +1 @@
-{"test_in_progress": "False", "language": "python", "template": "D:\\Alok country\\Apun coder banega\\Projects\\CP-CLI\\test\\code.cpp", "proxy": ""}
+{"user": {"firstname": "", "lastname": "", "rating": [""], "contri": [""], "rank": [""], "maxrating": ""}, "test_in_progress": "False", "language": "python", "template": "D:\\Alok country\\Apun coder banega\\Projects\\CP-CLI\\test\\code.cpp", "proxy": ""}


it will get easier if we call get-user method anywhere else in the code

akstron · 2022-10-21T14:38:52Z

src/Config/Config.py

+            config["user"]["firstname"] = html_content["result"][0]["firstName"]
+            config["user"]["lastname"] = html_content["result"][0]["lastName"]
+            config["user"]["rating"] = str(html_content["result"][0]["rating"]),
+            config["user"]["contri"] = str(html_content["result"][0]["contribution"]),
+            config["user"]["rank"] = str(html_content["result"][0]["rank"]),
+            config["user"]["maxrating"] = str(html_content["result"][0]["maxRating"])


There's an error over here which is causing creation of a list. Try to figure it out.

The commas 😢
removed em

akstron · 2022-10-22T07:24:17Z

src/Cli/config.py

+def get_user():
+    try:
+        config = Config()
+        click.echo(config.get_user())


As asked in the last review as well, why are you directly printing the object. Can you consider formatting it?

akstron · 2022-10-22T15:52:08Z

src/Config/Config.py

-        return config["user"]
+        for info in config["user"]:
+            print(info + " : " + str(config["user"][info]))


Earlier approach was correct. Receive user object from Config.py and print it in config.py

Link your codeforces profile with cli

8249846

added necessary chancges to link wiith cofeforces profile

ea7f49f

Merge branch 'ContriHUB:main' into main

7d5bab2

akstron reviewed Oct 11, 2022

View reviewed changes

ashutoshsuthar2020 added 3 commits October 11, 2022 21:41

made necessary changes to Config.py

7c51d6b

Update config.json

bd767dc

Update COMMANDS.md

7bec931

akstron reviewed Oct 12, 2022

View reviewed changes

Update Config.py

44c8c1b

akstron reviewed Oct 13, 2022

View reviewed changes

ashutoshsuthar2020 added 2 commits October 13, 2022 19:31

Update Config.py

a931d45

Update config.py

985d911

akstron reviewed Oct 14, 2022

View reviewed changes

added correct implemenatation of exception

fb226bd

akstron reviewed Oct 14, 2022

View reviewed changes

organised exception in config.py

7176f95

UserNotSet exception class created

51a66e9

api url varible formed

1c10403

akstron reviewed Oct 16, 2022

View reviewed changes

fixed the error on no proxy

6443bb6

reference : https://stackoverflow.com/questions/28521535/requests-how-to-disable-bypass-proxy

akstron reviewed Oct 20, 2022

View reviewed changes

ashutoshsuthar2020 added 3 commits October 20, 2022 20:12

Update UserNotSet.py

bdd40d8

Update config.py

5bf67ed

Update config.py

d06f904

ashutoshsuthar2020 commented Oct 20, 2022

View reviewed changes

akstron reviewed Oct 21, 2022

View reviewed changes

ashutoshsuthar2020 added 3 commits October 21, 2022 23:23

Update Config.py

993c76f

Update Config.py

c44e8d5

Update config.json

c029516

akstron reviewed Oct 22, 2022

View reviewed changes

ashutoshsuthar2020 added 2 commits October 22, 2022 13:41

Update Config.py

a12898e

Update config.py

22a768f

akstron reviewed Oct 22, 2022

View reviewed changes

DNA5769 mentioned this pull request Oct 30, 2022

Pick up random codeforces problem in test session #6

Closed

akstron added the hacktoberfest-accepted label Oct 30, 2022

akstron approved these changes Oct 30, 2022

View reviewed changes

		@@ -1 +1 @@
		{"test_in_progress": "False", "language": "python", "template": "D:\\Alok country\\Apun coder banega\\Projects\\CP-CLI\\test\\code.cpp", "proxy": ""} No newline at end of file
		{"user": {"firstname": "", "lastname": "", "rating": [""], "contri": [""], "rank": [""], "maxrating": ""}, "test_in_progress": "False", "language": "python", "template": "D:\\Alok country\\Apun coder banega\\Projects\\CP-CLI\\test\\code.cpp", "proxy": ""} No newline at end of file

Link your codeforces profile with cli #26

Are you sure you want to change the base?

Link your codeforces profile with cli #26

Uh oh!

Conversation

ashutoshsuthar2020 commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akstron commented Oct 11, 2022

Uh oh!

akstron commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashutoshsuthar2020 commented Oct 11, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashutoshsuthar2020 commented Oct 11, 2022

Uh oh!

akstron commented Oct 12, 2022

Uh oh!

ashutoshsuthar2020 commented Oct 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashutoshsuthar2020 commented Oct 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akstron commented Oct 16, 2022

Uh oh!

ashutoshsuthar2020 commented Oct 16, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashutoshsuthar2020 commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akstron commented Oct 18, 2022

Uh oh!

ashutoshsuthar2020 commented Oct 18, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashutoshsuthar2020 commented Oct 10, 2022 •

edited

Loading

akstron commented Oct 11, 2022 •

edited

Loading

ashutoshsuthar2020 commented Oct 18, 2022 •

edited

Loading

akstron Oct 21, 2022 •

edited

Loading

ashutoshsuthar2020 Oct 21, 2022 •

edited

Loading