facility to add more text and also delete them#22
facility to add more text and also delete them#22KIRTIKUMARKK21 wants to merge 2 commits intoContriHUB:mainfrom KIRTIKUMARKK21:Issue#8
Conversation
dev-lovedeep
left a comment
dev-lovedeep
left a comment
There was a problem hiding this comment.
i noticed your files are missing some changes from previous commit
one of them is , text was showing on the image.FIX that
| fetch(api_url) | ||
| .then((data) => data.json()) | ||
| .then((data) => setAllMemes(data.data.memes)); | ||
| }, []); |
There was a problem hiding this comment.
you have removed the catch part from some older commit or pull again
src/components/Meme.js
Outdated
|
|
||
| //this state stores information about the current meme | ||
| const [meme, setMeme] = useState({ | ||
| text: [], |
There was a problem hiding this comment.
texts would be better, bcz we have many
|
@dev-lovedeep I have taken pull from |
dev-lovedeep
left a comment
dev-lovedeep
left a comment
There was a problem hiding this comment.
are you extension or something, when i am checking the diff all the files have been changes although the content is same
| }; | ||
| //this is for handling the input | ||
| function handleChange(event) { | ||
| const { name, value } = event.target; |
There was a problem hiding this comment.
add check for empty input
| name="texts" | ||
| onChange={handleChange} | ||
| /> | ||
| <button type="submit" className="form__button"> |
There was a problem hiding this comment.
button should be coming next to the input box(in large screen view). Make it responsive
|
@KIRTIKUMARKK21 are you working on this issue? |
|
I thought 48 hrs is over and i will not able to contribute,still can I make changes? |
48 hours is limit for making the first commit |
|
Okay ,I am trying to solve the issues |
|
closed the PR? |
|
Sir I came back to hostel and was getting error while pushing through terminal .I am still not able to push ,my terminal git is not working under college proxy and my mobile network is very slow here. So i have deleted that repo and clones gain . |
|
I will go to library and try to push with mobile network. |
|
i have made another PR ,Please look into it. |
2 participants
Added feature to add text and also added to feature to delete text.Delete button occurs while we hover over the text.